LFLLMamdaniDefuzzifier - TestBisector fails

[matthiesenj]

Project built using MSYS GCC6.3.0 on Windows 10.
Test output is:

tests.exe is a Catch v1.12.1 host application.
Run with -? for options

---

LFLLMamdaniDefuzzifier - TestBisector

.../matthiesenj/LFLL/tests/mamdani/LFLLMamdaniDefuzzifierTest.cpp:99
...............................................................................

.../matthiesenj/LFLL/tests/mamdani/LFLLMamdaniDefuzzifierTest.cpp:131: FAILED:
REQUIRE( LFLL_APPROX(0.53103470802307129f) == ret )
with expansion:
Approx( 0.531034708 ) == 0.53126f

===============================================================================
test cases: 61 | 60 passed | 1 failed
assertions: 332 | 331 passed | 1 failed

I filed this issue to see if you have any pointers to why the test fails, i.e. compiler, Catch version, etc.
Is 0.53126f the actual value of ret ? (I don't really have any experience with Catch)

[nicopauss]

Hello,

retis the result of the defuzzification using MamdaniBisector.

I cannot reproduce it on linux gcc 4.9, linux clang 3.9, linux gcc 6.3, linux gcc 7.3 and mac gcc 4.2.
There are not leak or invalid memory access found with valgrind.
I couldn't test on Windows 10.

Can you give me the output of cmake .. && VERBOSE=1 make after a clean?
Can you try with another compiler, clang or VisualStudio?

I don't have time any more to maintain this project.
I have added you as collaborator, you now have push access to the repo.
Feel free to fix any bugs :)

[matthiesenj]

Hi,
thanks for the push access. How does the travis-ci stuff work? do I need my own account for it in order to trigger builds?

Output of cmake .. -G"MSYS Makefiles" && VERBOSE=1:

-- The CXX compiler identification is GNU 6.3.0
-- The C compiler identification is GNU 6.3.0
-- Check for working CXX compiler: C:/MinGW/bin/g++.exe
-- Check for working CXX compiler: C:/MinGW/bin/g++.exe -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Check for working C compiler: C:/MinGW/bin/gcc.exe
-- Check for working C compiler: C:/MinGW/bin/gcc.exe -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Setting build type to 'Release' as none was specified.
-- LFLL_INCLUDE_DIR = C:/Users/Jesper/repos/matthiesenj/LFLL
-- Could NOT find OpenMP_C (missing: OpenMP_C_FLAGS OpenMP_C_LIB_NAMES)
-- Could NOT find OpenMP_CXX (missing: OpenMP_CXX_FLAGS OpenMP_CXX_LIB_NAMES)
-- Could NOT find OpenMP (missing: OpenMP_C_FOUND OpenMP_CXX_FOUND)
-- OpenMP not found, openmp example has been deactivated
-- LFLL_INCLUDE_DIR = C:/Users/Jesper/repos/matthiesenj/LFLL
-- Looking for clock_gettime in rt
-- Looking for clock_gettime in rt - not found
-- Configuring done
-- Generating done
-- Build files have been written to: ..../matthiesenj/LFLL/build

I also tried building with gcc 6.30 on linux, and all tests pass there! (building fuzzylite fails there as well though, but due to some compilation problem related to the stream insertion operator).
All tests also pass on Windows using MSVC compiler (but here, the fuzzylite build fails with NMAKE : fatal error U1064: MAKEFILE not found and no target specified).