Coverity PR: Fix some minor issues or add improvements

* MongoDB: goto "out_err" in the new if-block, to free the resources
* mid-registrar: on mid_reg_save() quick-exit, check .flags before reply
* EVI: fix "infinite loop" bug in evi_remove_expired_subs()
* various whitespace fixes

Author: liviuchircu

evi/event_interface.c

@@ -137,7 +137,7 @@ void evi_remove_expired_subs(event_id_t id) {
 	while (subs) {
 		if (!subs->reply_sock) {
 			LM_ERR("unknown destination\n");
-			continue;
+			goto next_sub;
 		}
 		/* check expire */
 		if (!(subs->reply_sock->flags & EVI_PENDING) &&
@@ -163,6 +163,7 @@ void evi_remove_expired_subs(event_id_t id) {
 			}
 			continue;
 		}
+next_sub:
 		prev = subs;
 		subs = subs->next;
 	}
@@ -771,7 +772,7 @@ mi_response_t *w_mi_subscribers_list_1(const mi_params_t *params,
 	/* get the event id & before printing the subs list check for any expired subscribers and remove them*/
 	evid = evi_get_id(&event_s);
 	if (evid == -1)
-        return init_mi_error(404, MI_SSTR("Can't get the id"));
+		return init_mi_error(404, MI_SSTR("Can't get the id"));
 
 	evi_remove_expired_subs(evid);
 

modules/auth_aka/auth_aka.c

@@ -737,7 +737,7 @@ static int aka_challenge(struct sip_msg *_msg, struct aka_av_mgm *mgm, str *_rea
 
 	realm = (_realm?*_realm:str_init(""));
 	if (count > 1) {
-		avs = pkg_malloc(count * sizeof(struct aka_av *));
+		avs = pkg_malloc(count * sizeof *avs);
 		if (!avs) {
 			LM_ERR("could not allocate %d AVs\n", count);
 			return -1;

modules/auth_jwt/auth_jwt_certops.c

@@ -45,9 +45,9 @@ int extract_pub_key_from_cert(struct sip_msg* _msg, str* cert,
 	/* TODO - if x5c just add beggining & end */
 
 	if (cert == NULL) {
-        LM_ERR("Failed to parse certificate\n");
-        goto err_free;
-    }
+		LM_ERR("Failed to parse certificate\n");
+		return -1;
+	}
 
 	bio = BIO_new_mem_buf((void*)cert->s,cert->len);
 	if (!bio) {

modules/cachedb_mongodb/cachedb_mongodb_dbase.c

@@ -423,7 +423,7 @@ int mongo_raw_find(cachedb_con *con, bson_t *raw_query, bson_iter_t *ns,
 #if MONGOC_CHECK_VERSION(1, 5, 0)
 		if (!bson_append_document(opts, "projection", 10, &proj)) {
 			LM_ERR("failed to append doc\n");
-			return -1;
+			goto out_err;
 		}
 #else
 		fields = &proj;

modules/cachedb_mongodb/cachedb_mongodb_json.c

@@ -79,9 +79,9 @@ int json_to_bson_append_element(bson_t *doc, const char *k, struct json_object *
 
 	if (!v) {
 		if (!bson_append_null(doc, key, -1)) {
-            LM_ERR("failed to append NULL doc\n");
-            return -1;
-        }
+			LM_ERR("failed to append NULL doc\n");
+			return -1;
+		}
 
 		return 0;
 	}

modules/mid_registrar/save.c

@@ -2535,14 +2535,8 @@ int mid_reg_save(struct sip_msg *msg, udomain_t *d, struct save_flags *flags,
 	struct hdr_field *path;
 	int rc = -1, st, unlock_udomain = 0;
 
-	memset(&sctx, 0, sizeof sctx);
-	if (msg->REQ_METHOD != METHOD_REGISTER) {
-		LM_ERR("rejecting non-REGISTER SIP request (%d)\n", msg->REQ_METHOD);
-		rerrno = R_NOT_IMPL;
-		goto out_error;
-	}
-
 	rerrno = R_FINE;
+	memset(&sctx, 0, sizeof sctx);
 	sctx.cmatch.mode = CT_MATCH_NONE;
 	sctx.max_contacts = max_contacts;
 
@@ -2556,6 +2550,12 @@ int mid_reg_save(struct sip_msg *msg, udomain_t *d, struct save_flags *flags,
 		sctx.cmatch = flags->cmatch;
 	}
 
+	if (msg->REQ_METHOD != METHOD_REGISTER) {
+		LM_ERR("rejecting non-REGISTER SIP request (%d)\n", msg->REQ_METHOD);
+		rerrno = R_NOT_IMPL;
+		goto out_error;
+	}
+
 	if (parse_reg_headers(msg) != 0) {
 		LM_ERR("failed to parse req headers\n");
 		goto out_error;

modules/nat_traversal/nat_traversal.c

@@ -1932,9 +1932,9 @@ reply_filter(struct sip_msg *reply)
     str call_id;
 
     if (parse_headers(reply, HDR_VIA2_F, 0) < 0) {
-		LM_ERR("failed to parse message\n");
-		return -1;
-	}
+        LM_ERR("failed to parse message\n");
+        return -1;
+    }
 
     if (reply->via2)
         return 1;