Package downloads improvements #1526
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmgomez
force-pushed
the
async_downloads
branch
from
6bca548 to
c8ab53e
Compare
The version-agnostic cache directory changes in getCacheDownloadDir were causing lock file tests to fail because packages were getting cached with wrong VCS revisions. Now when useAsyncDownloads is false (default), it uses the old behavior with version in the cache path. When true, it uses the new version-agnostic caching that enables parallel downloads.
The condition was inverted - when useAsyncDownloads was true, it was using the sync path, and when false it was using the async path! Changed: - solvePackages: if isLegacy or useAsyncDownloads => if isLegacy or NOT useAsyncDownloads - getPkgVersionTable: Always used async => Now respects useAsyncDownloads flag This was causing all SAT solver tests to fail because they were inadvertently using the async path (which has version filtering removed) when they should use the stable sync path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.