Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use zlib:safeinflate/2 in cow_ws.erl? #139

Open
benbro opened this issue Aug 16, 2024 · 0 comments
Open

Use zlib:safeinflate/2 in cow_ws.erl? #139

benbro opened this issue Aug 16, 2024 · 0 comments

Comments

@benbro
Copy link

benbro commented Aug 16, 2024

Will it be better to replace zlib:inflate/2 with zlib:safeinflate/2
to prevent zlib-bomb as mentioned here?
https://github.com/ninenines/cowlib/blob/master/src/cow_ws.erl#L546 and few other places.

Is there a benchmark for cowboy WebScokets with and without compression? I'm trying to understand the memory, cpu and time overhead with compression and if it's stable and scalable for 1K connections.

Safari 15 had an issue with WebSocket connection when deflate is on. Maybe only when frames are fragmented. Cowboy never send fragmented packets, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant