Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows apps dir to contain symlinks #996

Open
FrancescoRestelli opened this issue Apr 18, 2024 · 1 comment
Open

Allows apps dir to contain symlinks #996

FrancescoRestelli opened this issue Apr 18, 2024 · 1 comment

Comments

@FrancescoRestelli
Copy link

FrancescoRestelli commented Apr 18, 2024

Hi,

We would like to be able to define common apps as symlinks when the app dir is override

issue:
Our project is a shared project between multiple platforms and some toolchains dont have all the builddeps needed to build all apps. so we must exclude some apps from the build process. the current local_deps only seems to exclude them from the release but still tries to build them.

to workaround this issues we separated the apps_dir into 2 dir
apps/common_app

apps_full/zookeeper
apps_full/common_app -> ../apps/common_app

then in the root makefile use it like this
ifeq ($(TYPE),full)
APPS_DIR=$(CURDIR)/apps_full
endif

in our project structure this works fine and solves the issue, when we add the -L to the "ALL_APP_DIRS find" (see pull request)

let me know what you think, thank you
#997

@essen
Copy link
Member

essen commented Jun 17, 2024

Hello, I have been scheming improvements to apps/* to avoid trying to rebuild everything every time, and I believe that the same mechanism to avoid building an app because it hasn't changed could be reused in your case to not build the app at all. It will take at least a few months before I am able to fully work on this though so your workaround will be helpful if anyone runs into this in the meantime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants