Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code refactoring v1.3.0 #42

Open
3 of 13 tasks
nineteendo opened this issue Jan 21, 2023 · 1 comment
Open
3 of 13 tasks

Code refactoring v1.3.0 #42

nineteendo opened this issue Jan 21, 2023 · 1 comment
Assignees
@nineteendo
Labels
enhancement New feature or request refactoring Improving logic
Milestone
Release v2.0.0

Comments

@nineteendo
Copy link
Owner

nineteendo commented Jan 21, 2023 •
edited
Loading

The code is currently a mess: enormous scripts with global variables and so on.
This has to be fixed to make this project more maintainable (06/01/2023 as suggested by Haruma):

  • no class for json encoding (11/12/2023).
  • move the conversion functions to libraries (07/01/2023).
  • raise errors from the error that caused it to provide a better error message (10/01/2023)
  • split up rton2json and json2rton (21/01/2023).
  • split up rijndael (21/01/2023).
  • no global variables (21/01/2023).
  • split unpack.py (21/01/2023)
  • split up patch.py (21/01/2023)
  • more comments (27/01/2023)
  • split up pyvz2.io (29/01/2023)
  • use functions for all colour formatting (02/02/2023)
  • split up max.py (Feb 7, 2023)
  • type annotations (Mar 3, 2023)
@nineteendo nineteendo added the enhancement New feature or request label Jan 21, 2023
@nineteendo nineteendo added this to the Release v1.3.0 milestone Jan 21, 2023
@nineteendo nineteendo self-assigned this Jan 21, 2023
@nineteendo nineteendo changed the title Code cleanup Code cleanup v1.3.0 Feb 6, 2023
@harumazzz
Copy link

More annotations for variables

@nineteendo nineteendo changed the title Code cleanup v1.3.0 Code refactoring v1.3.0 Jun 25, 2023
@nineteendo nineteendo added the refactoring Improving logic label Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nineteendo nineteendo

Labels
enhancement New feature or request refactoring Improving logic
Projects
None yet
Milestone
Release v2.0.0
Development

No branches or pull requests
2 participants
@nineteendo @harumazzz