Skip to content

Commit 0c485d3

Browse files
Remove unnecessary calls to _update_node_cache
- Apply suggestions from code review Co-authored-by: Chris Markiewicz <[email protected]>
1 parent 672a234 commit 0c485d3

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

nipype/pipeline/engine/workflows.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -273,7 +273,8 @@ def connect(self, *args, **kwargs):
273273
"(%s, %s): new edge data: %s", srcnode, destnode, str(edge_data)
274274
)
275275

276-
self._update_node_cache()
276+
if newnodes:
277+
self._update_node_cache()
277278

278279
def disconnect(self, *args):
279280
"""Disconnect nodes
@@ -320,8 +321,6 @@ def disconnect(self, *args):
320321
else:
321322
self._graph.add_edges_from([(srcnode, dstnode, edge_data)])
322323

323-
self._update_node_cache()
324-
325324
def add_nodes(self, nodes):
326325
""" Add nodes to a workflow
327326

0 commit comments

Comments
 (0)