Skip to content

Use separate LooseVersion package? #3468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
effigies opened this issue May 11, 2022 · 1 comment · Fixed by #3477
Closed

Use separate LooseVersion package? #3468

effigies opened this issue May 11, 2022 · 1 comment · Fixed by #3477

Comments

@effigies
Copy link
Member

Based on #3466 it seems like there's scope for multiple projects to do what we've done and end up with mutually incompatible LooseVersions. I can't see a very good reason to be comparing LooseVersions across modules, but even so a single source seems better than many.

I've taken what we did in #3466 and turned it into a package: https://pypi.org/project/looseversion/ (repo: https://github.com/effigies/looseversion)

Should we move to that instead of vendoring it locally?

@ghisvail
Copy link
Contributor

I am surprised nobody had done it yet, tbh. I can picture this being useful to other projects, so you might as well provide it as a separate package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants