Get rid of dontStrip for Darwin as it's no longer needed

Kranzes · Kranzes · commit 0209f258cda8 · 2024-06-16T16:21:41.000+03:00
Fixed in NixOS/nixpkgs#255900
diff --git a/crate2nix/Cargo.nix b/crate2nix/Cargo.nix
@@ -3101,8 +3101,6 @@ rec {
           buildRustCrateForPkgsFunc pkgs
             (
               crateConfig // {
-                # https://github.com/NixOS/nixpkgs/issues/218712
-                dontStrip = stdenv.hostPlatform.isDarwin;
                 src = crateConfig.src or (
                   pkgs.fetchurl rec {
                     name = "${crateConfig.crateName}-${crateConfig.version}.tar.gz";
diff --git a/crate2nix/templates/nix/crate2nix/default.nix b/crate2nix/templates/nix/crate2nix/default.nix
@@ -349,8 +349,6 @@ rec {
           buildRustCrateForPkgsFunc pkgs
             (
               crateConfig // {
-                # https://github.com/NixOS/nixpkgs/issues/218712
-                dontStrip = stdenv.hostPlatform.isDarwin;
                 src = crateConfig.src or (
                   pkgs.fetchurl rec {
                     name = "${crateConfig.crateName}-${crateConfig.version}.tar.gz";
diff --git a/sample_projects/bin_with_git_submodule_dep/Cargo.nix b/sample_projects/bin_with_git_submodule_dep/Cargo.nix
@@ -1695,8 +1695,6 @@ rec {
           buildRustCrateForPkgsFunc pkgs
             (
               crateConfig // {
-                # https://github.com/NixOS/nixpkgs/issues/218712
-                dontStrip = stdenv.hostPlatform.isDarwin;
                 src = crateConfig.src or (
                   pkgs.fetchurl rec {
                     name = "${crateConfig.crateName}-${crateConfig.version}.tar.gz";
diff --git a/sample_projects/codegen/Cargo.nix b/sample_projects/codegen/Cargo.nix
@@ -870,8 +870,6 @@ rec {
           buildRustCrateForPkgsFunc pkgs
             (
               crateConfig // {
-                # https://github.com/NixOS/nixpkgs/issues/218712
-                dontStrip = stdenv.hostPlatform.isDarwin;
                 src = crateConfig.src or (
                   pkgs.fetchurl rec {
                     name = "${crateConfig.crateName}-${crateConfig.version}.tar.gz";
diff --git a/sample_projects/sub_dir_crates/Cargo.nix b/sample_projects/sub_dir_crates/Cargo.nix
@@ -479,8 +479,6 @@ rec {
           buildRustCrateForPkgsFunc pkgs
             (
               crateConfig // {
-                # https://github.com/NixOS/nixpkgs/issues/218712
-                dontStrip = stdenv.hostPlatform.isDarwin;
                 src = crateConfig.src or (
                   pkgs.fetchurl rec {
                     name = "${crateConfig.crateName}-${crateConfig.version}.tar.gz";

Original file line number	Diff line number	Diff line change
`@@ -3101,8 +3101,6 @@ rec {`
`3101`	`3101`	`buildRustCrateForPkgsFunc pkgs`
`3102`	`3102`	`(`
`3103`	`3103`	`crateConfig // {`
`3104`		`- # https://github.com/NixOS/nixpkgs/issues/218712`
`3105`		`- dontStrip = stdenv.hostPlatform.isDarwin;`
`3106`	`3104`	`src = crateConfig.src or (`
`3107`	`3105`	`pkgs.fetchurl rec {`
`3108`	`3106`	`name = "${crateConfig.crateName}-${crateConfig.version}.tar.gz";`
Original file line number	Diff line number	Diff line change
`@@ -349,8 +349,6 @@ rec {`
`349`	`349`	`buildRustCrateForPkgsFunc pkgs`
`350`	`350`	`(`
`351`	`351`	`crateConfig // {`
`352`		`- # https://github.com/NixOS/nixpkgs/issues/218712`
`353`		`- dontStrip = stdenv.hostPlatform.isDarwin;`
`354`	`352`	`src = crateConfig.src or (`
`355`	`353`	`pkgs.fetchurl rec {`
`356`	`354`	`name = "${crateConfig.crateName}-${crateConfig.version}.tar.gz";`
Original file line number	Diff line number	Diff line change
`@@ -1695,8 +1695,6 @@ rec {`
`1695`	`1695`	`buildRustCrateForPkgsFunc pkgs`
`1696`	`1696`	`(`
`1697`	`1697`	`crateConfig // {`
`1698`		`- # https://github.com/NixOS/nixpkgs/issues/218712`
`1699`		`- dontStrip = stdenv.hostPlatform.isDarwin;`
`1700`	`1698`	`src = crateConfig.src or (`
`1701`	`1699`	`pkgs.fetchurl rec {`
`1702`	`1700`	`name = "${crateConfig.crateName}-${crateConfig.version}.tar.gz";`
Original file line number	Diff line number	Diff line change
`@@ -870,8 +870,6 @@ rec {`
`870`	`870`	`buildRustCrateForPkgsFunc pkgs`
`871`	`871`	`(`
`872`	`872`	`crateConfig // {`
`873`		`- # https://github.com/NixOS/nixpkgs/issues/218712`
`874`		`- dontStrip = stdenv.hostPlatform.isDarwin;`
`875`	`873`	`src = crateConfig.src or (`
`876`	`874`	`pkgs.fetchurl rec {`
`877`	`875`	`name = "${crateConfig.crateName}-${crateConfig.version}.tar.gz";`
Original file line number	Diff line number	Diff line change
`@@ -479,8 +479,6 @@ rec {`
`479`	`479`	`buildRustCrateForPkgsFunc pkgs`
`480`	`480`	`(`
`481`	`481`	`crateConfig // {`
`482`		`- # https://github.com/NixOS/nixpkgs/issues/218712`
`483`		`- dontStrip = stdenv.hostPlatform.isDarwin;`
`484`	`482`	`src = crateConfig.src or (`
`485`	`483`	`pkgs.fetchurl rec {`
`486`	`484`	`name = "${crateConfig.crateName}-${crateConfig.version}.tar.gz";`