Skip to content

Commit 26c4851

Browse files
authored
build: fix update-wpt workflow
PR-URL: #57468 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Filip Skokan <[email protected]>
1 parent 63e3cc7 commit 26c4851

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

.github/workflows/update-wpt.yml

+5-1
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,11 @@ jobs:
7070
- name: Open or update PR for the subsystem update
7171
uses: gr2m/create-or-update-pull-request-action@77596e3166f328b24613f7082ab30bf2d93079d5
7272
with:
73-
branch: actions/update-wpt-${{ matrix.subsystem }}
73+
# The create-or-update-pull-request-action matches the branch name by prefix,
74+
# which is why we need to add the -wpt suffix. If we dont do that, we risk matching wrong PRs,
75+
# like for example "url" mistakenly matching and updating the "urlpattern" PR
76+
# as seen in https://github.com/nodejs/node/pull/57368
77+
branch: actions/update-${{ matrix.subsystem }}-wpt
7478
author: Node.js GitHub Bot <[email protected]>
7579
title: 'test: update WPT for ${{ matrix.subsystem }} to ${{ env.short_version }}'
7680
commit-message: 'test: update WPT for ${{ matrix.subsystem }} to ${{ env.short_version }}'

0 commit comments

Comments
 (0)