Skip to content

Commit 565e5e1

Browse files
committed
fs: ensure dir.read() does not throw synchronously
PR-URL: #58228 Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
1 parent dc7ec42 commit 565e5e1

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

lib/internal/fs/dir.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ class Dir {
9494
}
9595

9696
read(callback) {
97-
return this.#readImpl(true, callback);
97+
return arguments.length === 0 ? this.#readPromisified() : this.#readImpl(true, callback);
9898
}
9999

100100
#readImpl(maybeSync, callback) {

test/parallel/test-fs-opendir.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,7 @@ async function doAsyncIterBreakTest() {
160160
break;
161161
}
162162

163-
await assert.rejects(async () => dir.read(), dirclosedError);
163+
await assert.rejects(dir.read(), dirclosedError);
164164
}
165165
doAsyncIterBreakTest().then(common.mustCall());
166166

@@ -172,7 +172,7 @@ async function doAsyncIterReturnTest() {
172172
}
173173
})();
174174

175-
await assert.rejects(async () => dir.read(), dirclosedError);
175+
await assert.rejects(dir.read(), dirclosedError);
176176
}
177177
doAsyncIterReturnTest().then(common.mustCall());
178178

@@ -188,7 +188,7 @@ async function doAsyncIterThrowTest() {
188188
}
189189
}
190190

191-
await assert.rejects(async () => dir.read(), dirclosedError);
191+
await assert.rejects(dir.read(), dirclosedError);
192192
}
193193
doAsyncIterThrowTest().then(common.mustCall());
194194

0 commit comments

Comments
 (0)