Skip to content

Commit 7c47614

Browse files
committed
test: expect seed-only PQC PKCS#8 export with BoringSSL
test-crypto-pqc-key-objects-ml-dsa and -ml-kem compare a seeded key's PKCS#8 export against the seed+expanded fixture on every backend. BoringSSL only writes the seed-only encoding, so expect the private_seed_only fixture there. main expects seed-only on every backend since #62178, which is semver-major, so the BoringSSL support backported in #63563 kept the old expectation. Refs: #63563 Signed-off-by: Shelley Vohr <shelley.vohr@gmail.com>
1 parent e711d3f commit 7c47614

2 files changed

Lines changed: 4 additions & 2 deletions

File tree

‎test/parallel/test-crypto-pqc-key-objects-ml-dsa.js‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,8 @@ for (const [asymmetricKeyType, pubLen] of [
7979
assertPublicKey(createPublicKey(key));
8080
key.export({ format: 'der', type: 'pkcs8' });
8181
if (hasSeed) {
82-
assert.strictEqual(key.export({ format: 'pem', type: 'pkcs8' }), keys.private);
82+
const expectedPkcs8 = process.features.openssl_is_boringssl ? keys.private_seed_only : keys.private;
83+
assert.strictEqual(key.export({ format: 'pem', type: 'pkcs8' }), expectedPkcs8);
8384
const jwk = key.export({ format: 'jwk' });
8485
assertPrivateJwk(jwk);
8586
assert.strictEqual(key.equals(createPrivateKey({ format: 'jwk', key: jwk })), true);

‎test/parallel/test-crypto-pqc-key-objects-ml-kem.js‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,8 @@ for (const [asymmetricKeyType, pubLen] of [
7979
assertPublicKey(createPublicKey(key));
8080
key.export({ format: 'der', type: 'pkcs8' });
8181
if (hasSeed) {
82-
assert.strictEqual(key.export({ format: 'pem', type: 'pkcs8' }), keys.private);
82+
const expectedPkcs8 = process.features.openssl_is_boringssl ? keys.private_seed_only : keys.private;
83+
assert.strictEqual(key.export({ format: 'pem', type: 'pkcs8' }), expectedPkcs8);
8384
const jwk = key.export({ format: 'jwk' });
8485
assertPrivateJwk(jwk);
8586
assert.strictEqual(key.equals(createPrivateKey({ format: 'jwk', key: jwk })), true);

0 commit comments

Comments
 (0)