crypto: improvement random syncrone number creating performance

this pr improve random syncron number creator

node git:(main) ✗ npx node-benchmark-compare rb.csv
                                          confidence improvement accuracy (*)   (**)  (***)
crypto/randomBytes.js n=100000 size=1024         ***     77.15 %       ±3.14% ±4.18% ±5.45%
crypto/randomBytes.js n=100000 size=16384                -4.11 %       ±5.22% ±6.95% ±9.04%
crypto/randomBytes.js n=100000 size=64           ***    107.53 %       ±5.13% ±6.85% ±8.96%
crypto/randomBytes.js n=100000 size=8192         ***     24.62 %       ±4.48% ±5.98% ±7.81%

Assisted-by:Claude Code Opus 5.5
Signed-off-by: Mert Can Altin <mertgold60@gmail.com>

Author: mertcanaltin

lib/internal/crypto/random.js

@@ -34,6 +34,7 @@ const {
   CheckPrimeJob,
   kCryptoJobAsync,
   kCryptoJobSync,
+  randomFillSync: randomFillSyncImpl,
   secureBuffer,
 } = internalBinding('crypto');
 
@@ -175,16 +176,7 @@ function randomFillSync(buf, offset = 0, size) {
   if (size === 0)
     return buf;
 
-  const job = new RandomBytesJob(
-    kCryptoJobSync,
-    buf,
-    offset,
-    size);
-
-  const err = job.run()[0];
-  if (err)
-    throw err;
-
+  randomFillSyncImpl(buf, offset, size);
   return buf;
 }
 

src/crypto/crypto_random.cc

@@ -214,13 +214,33 @@ MaybeLocal<Value> CheckPrimeTraits::EncodeOutput(Environment* env,
 }
 
 namespace Random {
+static void RandomFillSync(const FunctionCallbackInfo<Value>& args) {
+  Environment* env = Environment::GetCurrent(args);
+  CHECK(IsAnyBufferSource(args[0]));  // Buffer to fill
+  CHECK(args[1]->IsUint32());  // Offset
+  CHECK(args[2]->IsUint32());  // Size
+
+  ArrayBufferOrViewContents<unsigned char> in(args[0]);
+
+  const uint32_t byte_offset = args[1].As<Uint32>()->Value();
+  const uint32_t size = args[2].As<Uint32>()->Value();
+  CHECK_GE(byte_offset + size, byte_offset);  // Overflow check.
+  CHECK_LE(byte_offset + size, in.size());  // Bounds check.
+
+  if (!ncrypto::CSPRNG(in.data() + byte_offset, size)) {
+    THROW_ERR_CRYPTO_OPERATION_FAILED(env, "Deriving bits failed");
+  }
+}
+
 void Initialize(Environment* env, Local<Object> target) {
+  SetMethod(env->context(), target, "randomFillSync", RandomFillSync);
   RandomBytesJob::Initialize(env, target);
   RandomPrimeJob::Initialize(env, target);
   CheckPrimeJob::Initialize(env, target);
 }
 
 void RegisterExternalReferences(ExternalReferenceRegistry* registry) {
+  registry->Register(RandomFillSync);
   RandomBytesJob::RegisterExternalReferences(registry);
   RandomPrimeJob::RegisterExternalReferences(registry);
   CheckPrimeJob::RegisterExternalReferences(registry);