Skip to content

Commit 8a6d0f1

Browse files
committed
fixup! assert,util: fix constructor lookup in deep equal comparison
This prevents the array iterator being called to make sure the test passes.
1 parent 47a12cb commit 8a6d0f1

File tree

1 file changed

+33
-34
lines changed

1 file changed

+33
-34
lines changed

lib/internal/util/comparisons.js

Lines changed: 33 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -60,40 +60,39 @@ const { isURL } = require('internal/url');
6060
const { isError } = require('internal/util');
6161
const { Buffer } = require('buffer');
6262

63-
const wellKnownConstructors = new SafeSet([
64-
Array,
65-
ArrayBuffer,
66-
BigInt,
67-
BigInt64Array,
68-
BigUint64Array,
69-
Boolean,
70-
Buffer,
71-
DataView,
72-
Date,
73-
Error,
74-
Float16Array,
75-
Float32Array,
76-
Float64Array,
77-
Function,
78-
Int16Array,
79-
Int32Array,
80-
Int8Array,
81-
Map,
82-
Number,
83-
Object,
84-
Promise,
85-
RegExp,
86-
Set,
87-
SharedArrayBuffer,
88-
String,
89-
Symbol,
90-
Uint16Array,
91-
Uint32Array,
92-
Uint8Array,
93-
Uint8ClampedArray,
94-
WeakMap,
95-
WeakSet,
96-
]);
63+
const wellKnownConstructors = new SafeSet()
64+
wellKnownConstructors.add(Array);
65+
wellKnownConstructors.add(ArrayBuffer);
66+
wellKnownConstructors.add(BigInt);
67+
wellKnownConstructors.add(BigInt64Array);
68+
wellKnownConstructors.add(BigUint64Array);
69+
wellKnownConstructors.add(Boolean);
70+
wellKnownConstructors.add(Buffer);
71+
wellKnownConstructors.add(DataView);
72+
wellKnownConstructors.add(Date);
73+
wellKnownConstructors.add(Error);
74+
wellKnownConstructors.add(Float16Array);
75+
wellKnownConstructors.add(Float32Array);
76+
wellKnownConstructors.add(Float64Array);
77+
wellKnownConstructors.add(Function);
78+
wellKnownConstructors.add(Int16Array);
79+
wellKnownConstructors.add(Int32Array);
80+
wellKnownConstructors.add(Int8Array);
81+
wellKnownConstructors.add(Map);
82+
wellKnownConstructors.add(Number);
83+
wellKnownConstructors.add(Object);
84+
wellKnownConstructors.add(Promise);
85+
wellKnownConstructors.add(RegExp);
86+
wellKnownConstructors.add(Set);
87+
wellKnownConstructors.add(SharedArrayBuffer);
88+
wellKnownConstructors.add(String);
89+
wellKnownConstructors.add(Symbol);
90+
wellKnownConstructors.add(Uint16Array);
91+
wellKnownConstructors.add(Uint32Array);
92+
wellKnownConstructors.add(Uint8Array);
93+
wellKnownConstructors.add(Uint8ClampedArray);
94+
wellKnownConstructors.add(WeakMap);
95+
wellKnownConstructors.add(WeakSet);
9796

9897
const types = require('internal/util/types');
9998
const {

0 commit comments

Comments
 (0)