Skip to content

"Create Release Proposal" GHA does not trigger pull_request#opened workflows #58096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marco-ippolito opened this issue May 1, 2025 · 7 comments
Labels
build Issues and PRs related to build files or the CI.

Comments

@marco-ippolito
Copy link
Member

marco-ippolito commented May 1, 2025

Version

No response

Platform

Subsystem

No response

What steps will reproduce the bug?

Opening a release proposal PR with GHA does not trigger the GHA CI workflow. Similar discussions https://github.com/orgs/community/discussions/65321

How often does it reproduce? Is there a required condition?

Always

What is the expected behavior? Why is that the expected behavior?

That it triggers the CI

What do you see instead?

GHA workflows not being triggered

Additional information

Workaround is to use a PAT instead of github token

@nodejs/build @nodejs/releasers

@marco-ippolito marco-ippolito added the build Issues and PRs related to build files or the CI. label May 1, 2025
@aduh95
Copy link
Contributor

aduh95 commented May 1, 2025

Do we create releases with GHA? Not on this repo I don’t think

@marco-ippolito
Copy link
Member Author

#57896 this was created by a github bot

@richardlau
Copy link
Member

Do we create releases with GHA? Not on this repo I don’t think

In today's Build WG call we were discussing why #57994 didn't get picked up before #57896 landed. Part of the discussion was the possibility that opening the PR via GitHub Actions (if that was how it was opened) may not trigger other GitHub workflows.

@aduh95
Copy link
Contributor

aduh95 commented May 1, 2025

Ah you meant opening the release proposal PR, not creating the GH release

@aduh95 aduh95 changed the title Release GHA does not trigger GHA CI "Create Release Proposal" GHA does not trigger "Linters (release proposals)" workflow May 5, 2025
@aduh95 aduh95 changed the title "Create Release Proposal" GHA does not trigger "Linters (release proposals)" workflow "Create Release Proposal" GHA does not trigger pull_request#opened workflows May 5, 2025
@targos
Copy link
Member

targos commented May 8, 2025

#58226 was opened by the workflow and triggered the workflows.

@aduh95
Copy link
Contributor

aduh95 commented May 8, 2025

#58226 was opened by the workflow and triggered the workflows.

To be more precise, opening it did not trigger the workflows, marking it as Ready for reviews did.

@targos
Copy link
Member

targos commented May 8, 2025

Seems to be working as intended to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI.
Projects
None yet
Development

No branches or pull requests

4 participants