Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Proposal for configurable way to npm install only the desired files from npm modules #208

Open
Emuentes opened this issue May 13, 2019 · 4 comments
Labels
discussion The decision process is still ongoing vendor Some vendor need to be onboard

Comments

@Emuentes
Copy link
Contributor

No description provided.

@ljharb
Copy link
Member

ljharb commented May 13, 2019

Combined with a way for package authors to specify which files are needed for production, or not.

@dominykas
Copy link
Member

Aren't this and #209 essentially duplicates? It all starts with a definition, and the definition can be worded as the RFC? Which can then have two parallel implementation paths - cleaning as part of npm prune (already works for dev deps, so only needs to be extended for files) and not installing as npm install in the first place (but presumably only when run as --production)?

@ljharb
Copy link
Member

ljharb commented May 14, 2019

This is different from dev/prod - you’d want dev deps installed, but with minimal files.

@dominykas
Copy link
Member

Sure, the setting to prune the deps to prod-only deps should not be the same setting to prune the files to prod-only files, but I believe this can still be implemented as a flag for both - prune and install.

We've learnt that mistake with npm-shrinkwrap and package-lock controlled by the same setting...

@Eomm Eomm added discussion The decision process is still ongoing vendor Some vendor need to be onboard labels Aug 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion The decision process is still ongoing vendor Some vendor need to be onboard
Projects
None yet
Development

No branches or pull requests

4 participants