Skip to content

Inexistent URL to a CSS skin after activation but before the plugin settings are saved #3

Description

@jflagarde

Issue Description

After activation of the plugin and before we save any settings in the Granular Controls tab, when the Elementor Editor is opened, the plugin tries to load a non-existent CSS skin at URL "/wp-content/plugins/granular-controls-for-elementor/assets/css/elementor--skin.css". The file "elementor--skin.css" doesn't exist and an error is reported in the browser debugger console.

Expected Behaviour

After activation, the proper default CSS skin should be loaded, or the default Elementor skin should be used.

Possible Problem and Solution

The plugin should have the same behaviour after activation and before the settings are saved. The plugin doesn't seem to load any CSS skin when the default skin is selected and saved. However, it tries to load the inexistent file if nothing is selected. There must be an if statement missing to handle the null selected value.

Steps to reproduce

  • On a fresh WP install;
  • Install + activate Elementor;
  • Install + activate Granular Controls, but do not save any settings in the Granular Controls tab;
  • Edit a page in Elementor;
  • Open the browser debugger and notice the error concerning elementor--skin.css file missing.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions