From e9313b1d1744215b6b965814aaf0d38ac3b77107 Mon Sep 17 00:00:00 2001 From: Jeremy Friesen Date: Mon, 19 Feb 2024 10:19:49 -0500 Subject: [PATCH] =?UTF-8?q?=E2=98=91=EF=B8=8F=20Remove=20ChangeSet#prepopu?= =?UTF-8?q?late!=20test?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This test is fragile in that it does not account for the fact that we can specify a :prepopulate option for a property. When you specify the `:prepopulate` option (as in `Hyrax::Form::PcdmCollection`) and use this shared spec, then the now deleted spec fails with no recourse. Related to: - https://github.com/samvera/hyrax/issues/6702 - https://github.com/samvera/hyrax/pull/6703 --- lib/valkyrie/specs/shared_specs/change_set.rb | 8 -------- 1 file changed, 8 deletions(-) diff --git a/lib/valkyrie/specs/shared_specs/change_set.rb b/lib/valkyrie/specs/shared_specs/change_set.rb index 0d573cd69..5f92d7fe5 100644 --- a/lib/valkyrie/specs/shared_specs/change_set.rb +++ b/lib/valkyrie/specs/shared_specs/change_set.rb @@ -41,14 +41,6 @@ end end - describe "#prepopulate!" do - it "doesn't make it look changed" do - expect(change_set).not_to be_changed - change_set.prepopulate! - expect(change_set).not_to be_changed - end - end - describe "#required?" do it "returns a boolean" do expect(change_set.required?(change_set.fields.keys.first)).to be_in [true, false]