-
Notifications
You must be signed in to change notification settings - Fork 1.4k
docs: matter: light swithc: fixed descriminator change note #26085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
CI InformationTo view the history of this post, click the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 9d5079cdb000f7db940b061ce42126ebeebd14d5 more detailssdk-nrf:
Github labels
List of changed files detected by CI (15)Outputs:ToolchainVersion: Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
| When one device is commissioned, power up the next device and perform the commissioning. | ||
|
|
||
| To avoid this unclear situation, you can set up your unique discriminator in the :file:`src/chip_project_config.h` file by changing the :kconfig:option:`CHIP_DEVICE_CONFIG_USE_TEST_SETUP_DISCRIMINATOR` value. | ||
| To avoid this unclear situation, you can set up your unique discriminator in the :file:`prj.conf` file by setting the value of :kconfig:option:`CONFIG_CHIP_DEVICE_DISCRIMINATOR`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| To avoid this unclear situation, you can set up your unique discriminator in the :file:`prj.conf` file by setting the value of :kconfig:option:`CONFIG_CHIP_DEVICE_DISCRIMINATOR`. | |
| To avoid this unclear situation, set the value of the :kconfig:option:`CONFIG_CHIP_DEVICE_DISCRIMINATOR` Kconfig option in the :file:`prj.conf` file to adjust your unique discriminator. |
b23581b to
1de373e
Compare
| When one device is commissioned, power up the next device and perform the commissioning. | ||
|
|
||
| To avoid this unclear situation, you can set up your unique discriminator in the :file:`src/chip_project_config.h` file by changing the :kconfig:option:`CHIP_DEVICE_CONFIG_USE_TEST_SETUP_DISCRIMINATOR` value. | ||
| To avoid this unclear situation, set the value of the :kconfig:option:`CONFIG_CHIP_DEVICE_DISCRIMINATOR` Kconfig option in the :file:`prj.conf` file to adjust your unique discriminator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to mention prj.conf at all? In some configurations this wont be accurate e.g. prj_release.conf etc.
|
Maybe I wasn't precise in the ticket description, but besides of fixing this particular line, generally the issue is that people do not know how to test multiple devices without a problem with identifying them. My idea was to:
|
1de373e to
80e5ed9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure If this is enough to put it here to then later use it in the other places.
I am also not sure if the ref will work.
I wanted to refer to doc/nrf/protocols/matter/getting_started/advanced_kconfigs.rst (the section I edited)
80e5ed9 to
14e2307
Compare
| * :kconfig:option:`CONFIG_CHIP_DEVICE_DISCRIMINATOR` sets the Bluetooth LE discriminator of the device. | ||
| In each sample it is set to the same value by default (hexadecimal: ``0xF00``; decimal: ``3840``). | ||
| Without changing the discriminator only one uncommissioned device can be powered up at the same time. | ||
| If multiple devices with the same discriminator are powered simultaneously, the CHIP Tool will commission a random device. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| If multiple devices with the same discriminator are powered simultaneously, the CHIP Tool will commission a random device. | |
| If multiple devices with the same discriminator are powered simultaneously, the Matter controller will commission a random device. |
Fixed an outdated discriminator update note Signed-off-by: Adam Maciuga <[email protected]>
14e2307 to
9d5079c
Compare
Fixed an outdated discriminator update note