Skip to content

Conversation

@Adam-Maciuga
Copy link
Contributor

Fixed an outdated discriminator update note

@Adam-Maciuga Adam-Maciuga requested a review from a team as a code owner December 4, 2025 12:23
@NordicBuilder NordicBuilder added doc-required PR must not be merged without tech writer approval. changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Dec 4, 2025
@NordicBuilder NordicBuilder requested a review from a team December 4, 2025 12:24
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Dec 4, 2025

CI Information

To view the history of this post, click the 'edited' button above
Build number: 5

Inputs:

Sources:

sdk-nrf: PR head: 9d5079cdb000f7db940b061ce42126ebeebd14d5

more details

sdk-nrf:

PR head: 9d5079cdb000f7db940b061ce42126ebeebd14d5
merge base: d0f84cb57d7e07a99e2cd487eeb8c0503dd579de
target head (main): 1ddde354b13178e9107e694ba8a3c0cc558db2c8
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (15)
applications
│  ├── matter_bridge
│  │  ├── doc
│  │  │  │ matter_bridge_description.rst
│  ├── matter_weather_station
│  │  │ README.rst
doc
│  ├── nrf
│  │  ├── protocols
│  │  │  ├── matter
│  │  │  │  ├── getting_started
│  │  │  │  │  │ advanced_kconfigs.rst
│  │  │ shortcuts.txt
samples
│  ├── matter
│  │  ├── closure
│  │  │  │ README.rst
│  │  ├── contact_sensor
│  │  │  │ README.rst
│  │  ├── light_bulb
│  │  │  │ README.rst
│  │  ├── light_switch
│  │  │  │ README.rst
│  │  ├── lock
│  │  │  │ README.rst
│  │  ├── manufacturer_specific
│  │  │  │ README.rst
│  │  ├── smoke_co_alarm
│  │  │  │ README.rst
│  │  ├── temperature_sensor
│  │  │  │ README.rst
│  │  ├── template
│  │  │  │ README.rst
│  │  ├── thermostat
│  │  │  │ README.rst
│  │  ├── window_covering
│  │  │  │ README.rst

Outputs:

Toolchain

Version:
Build docker image:

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain
  • ◻️ Build twister
  • ◻️ Integration tests
Disabled integration tests
    • test-fw-nrfconnect-nrf_lrcs_mosh
    • test-fw-nrfconnect-nrf_lrcs_positioning
    • desktop52_verification
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-ps-main
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread-main
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

When one device is commissioned, power up the next device and perform the commissioning.

To avoid this unclear situation, you can set up your unique discriminator in the :file:`src/chip_project_config.h` file by changing the :kconfig:option:`CHIP_DEVICE_CONFIG_USE_TEST_SETUP_DISCRIMINATOR` value.
To avoid this unclear situation, you can set up your unique discriminator in the :file:`prj.conf` file by setting the value of :kconfig:option:`CONFIG_CHIP_DEVICE_DISCRIMINATOR`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To avoid this unclear situation, you can set up your unique discriminator in the :file:`prj.conf` file by setting the value of :kconfig:option:`CONFIG_CHIP_DEVICE_DISCRIMINATOR`.
To avoid this unclear situation, set the value of the :kconfig:option:`CONFIG_CHIP_DEVICE_DISCRIMINATOR` Kconfig option in the :file:`prj.conf` file to adjust your unique discriminator.

When one device is commissioned, power up the next device and perform the commissioning.

To avoid this unclear situation, you can set up your unique discriminator in the :file:`src/chip_project_config.h` file by changing the :kconfig:option:`CHIP_DEVICE_CONFIG_USE_TEST_SETUP_DISCRIMINATOR` value.
To avoid this unclear situation, set the value of the :kconfig:option:`CONFIG_CHIP_DEVICE_DISCRIMINATOR` Kconfig option in the :file:`prj.conf` file to adjust your unique discriminator.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to mention prj.conf at all? In some configurations this wont be accurate e.g. prj_release.conf etc.

@kkasperczyk-no
Copy link
Contributor

Maybe I wasn't precise in the ticket description, but besides of fixing this particular line, generally the issue is that people do not know how to test multiple devices without a problem with identifying them. My idea was to:

  1. Add some generic info that you can use discriminator and this kconfig to customize it, so you will not confuse multiple devices on desk. For example it could be added here: https://docs.nordicsemi.com/bundle/ncs-latest/page/nrf/protocols/matter/getting_started/advanced_kconfigs.html#matter_device_identification
  2. Add one liner to every readme that says, if you want to test multiple devices and not confuse them blah blah, see this link: ...

@github-actions
Copy link

github-actions bot commented Dec 4, 2025

@Adam-Maciuga Adam-Maciuga requested a review from a team as a code owner December 4, 2025 14:55
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure If this is enough to put it here to then later use it in the other places.
I am also not sure if the ref will work.
I wanted to refer to doc/nrf/protocols/matter/getting_started/advanced_kconfigs.rst (the section I edited)

* :kconfig:option:`CONFIG_CHIP_DEVICE_DISCRIMINATOR` sets the Bluetooth LE discriminator of the device.
In each sample it is set to the same value by default (hexadecimal: ``0xF00``; decimal: ``3840``).
Without changing the discriminator only one uncommissioned device can be powered up at the same time.
If multiple devices with the same discriminator are powered simultaneously, the CHIP Tool will commission a random device.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If multiple devices with the same discriminator are powered simultaneously, the CHIP Tool will commission a random device.
If multiple devices with the same discriminator are powered simultaneously, the Matter controller will commission a random device.

Fixed an outdated discriminator update note

Signed-off-by: Adam Maciuga <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. doc-required PR must not be merged without tech writer approval.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants