Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.bad files are created when r/w operations happen alternately until queue file is rolled #38

Open
lootek opened this issue Jun 21, 2022 · 1 comment · May be fixed by #41
Open

.bad files are created when r/w operations happen alternately until queue file is rolled #38

lootek opened this issue Jun 21, 2022 · 1 comment · May be fixed by #41
Labels
bug

Comments

@lootek
Copy link

lootek commented Jun 21, 2022

Reproduction as unit test: #37
@lootek lootek changed the title .bad files are created when queue is rolled and r/w is happening concurrently .bad files are created when r/w operations happen alternately until queue file is rolled Jun 21, 2022
@mreiferson
Copy link
Member

Nice find. This is broken because we check to roll the file on write at the beginning of writeOne(), so when the size of the file reaches maxBytesPerFile (exactly), it doesn't roll until the next write.

@mreiferson mreiferson added the bug label Jun 24, 2022
@mreiferson mreiferson linked a pull request May 30, 2023 that will close this issue
Open
@mreiferson mreiferson mentioned this issue Oct 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

check current file against maxBytesPerFile mreiferson/go-diskqueue
2 participants
@mreiferson @lootek