Fix rich comparison

Author: juntyr

quaddtype/numpy_quaddtype/src/ops.hpp

@@ -386,7 +386,7 @@ quad_equal(const Sleef_quad *a, const Sleef_quad *b)
 static inline npy_bool
 quad_notequal(const Sleef_quad *a, const Sleef_quad *b)
 {
-    return Sleef_icmpneq1(*a, *b) | Sleef_iunordq1(*a, *b);
+    return Sleef_icmpneq1(*a, *b) || Sleef_iunordq1(*a, *b);
 }
 
 static inline npy_bool

quaddtype/numpy_quaddtype/src/scalar_ops.cpp

@@ -163,7 +163,7 @@ quad_richcompare(QuadPrecisionObject *self, PyObject *other, int cmp_op)
                 cmp = Sleef_icmpeqq1(self->value.sleef_value, other_quad->value.sleef_value);
                 break;
             case Py_NE:
-                cmp = Sleef_icmpneq1(self->value.sleef_value, other_quad->value.sleef_value);
+                cmp = Sleef_icmpneq1(self->value.sleef_value, other_quad->value.sleef_value) || Sleef_iunordq1(self->value.sleef_value, other_quad->value.sleef_value);
                 break;
             case Py_GT:
                 cmp = Sleef_icmpgtq1(self->value.sleef_value, other_quad->value.sleef_value);

quaddtype/tests/test_quaddtype.py

@@ -45,6 +45,19 @@ def test_comparisons(op, a, b):
     assert op_func(quad_a, quad_b) == op_func(float_a, float_b)
 
 
+@pytest.mark.parametrize("op", ["eq", "ne", "le", "lt", "ge", "gt"])
+@pytest.mark.parametrize("a", ["3.0", "12.5", "100.0", "inf", "-inf", "nan", "-nan"])
+@pytest.mark.parametrize("b", ["3.0", "12.5", "100.0", "inf", "-inf", "nan", "-nan"])
+def test_array_comparisons(op, a, b):
+    op_func = getattr(operator, op)
+    quad_a = np.array(QuadPrecision(a))
+    quad_b = np.array(QuadPrecision(b))
+    float_a = np.array(float(a))
+    float_b = np.array(float(b))
+
+    assert np.array_equal(op_func(quad_a, quad_b), op_func(float_a, float_b))
+
+
 @pytest.mark.parametrize("op, val, expected", [
     ("neg", "3.0", "-3.0"),
     ("neg", "-3.0", "3.0"),