valgrind error should be fixed

Author: nursultan-a

LinkedList.hpp

@@ -78,7 +78,6 @@ LinkedList<T>::LinkedList(const LinkedList &obj)
 
 
         while(givenCurrent != obj.tail){
-            // cout << "creating node for node with dadta:  " << givenCurrent->element << endl;
             givenCurrent = givenCurrent->next;
             if(givenCurrent != obj.tail){
                 newCurrent->next = new Node<T>(givenCurrent->element, newCurrent, NULL);
@@ -88,7 +87,6 @@ LinkedList<T>::LinkedList(const LinkedList &obj)
         }
         tail->prev = newCurrent;
         newCurrent->next = tail;
-        // cout << "tail element?: " << tail->element << endl;
     }
     else{
         head->next = tail;
@@ -105,7 +103,9 @@ LinkedList<T>::~LinkedList()
         tmp = head->next;
         delete head;
         head = tmp;
-    }        
+    }
+    tail = NULL;
+    head = NULL; 
 }
 
 template<class T>
@@ -214,6 +214,7 @@ void LinkedList<T>::removeNode(Node<T> *node)
         node->next = NULL;
         node->prev = NULL;
         delete node;//CHECK: is it right way?
+        node = NULL;
     }
 }
 
@@ -224,22 +225,17 @@ void LinkedList<T>::removeAllNodes()
 {
     /* TODO */
     Node<T> *current = head->next;
-    Node<T> *deletable = NULL;
 
     while(current != tail){
-        current->prev->next = current->next;
-        current->next->prev = current->prev;
-
-        deletable = current;
-        current = current->next;
+        head->next = current->next;
+        current->next->prev = head;
 
-        deletable->prev = NULL;
-        deletable->next = NULL;
-        delete deletable;
+        delete current;
+        current = head->next;
 
     }
+    current = NULL;
     tail->prev = head;
-    head->next = tail;
 }
 
 template<class T>

Makefile

@@ -1,5 +1,5 @@
 CC=g++
-CFLAGS=-c -ansi -Wall -pedantic-errors -O0
+CFLAGS=-c -g -ansi -Wall -pedantic-errors -O0
 
 all: linkedlist browser
 

WebHistory.cpp

@@ -69,11 +69,14 @@ void WebHistory::printHistory()
 WebHistory::WebHistory(std::string url, int timestamp)
 {
 	// TODO
+
+	history.insertAtTheEnd(Tab(url, timestamp));
 }
 
 WebHistory::~WebHistory()
 {
 	// TODO
+
 }
 
 void WebHistory::insertInOrder(Node<Tab> *newPage)

browser

@@ -7,82 +7,25 @@ using namespace std;
 int main() {
     LinkedList<int> llist;
 
-    // Default constructor
-    cout << "--- Default constructor start---" << endl;
-    llist.printAllNodes();
-    cout << "--- Default constructor start---" << endl;
-    cout << "##########" << endl;
-    cout << "--- Print all nodes start ---" << endl;
-    llist.printAllNodes();
-    cout << "---Print all nodes end ---" << endl;
-
-    
-    cout << "##########" << endl;
-    cout << "--- Insert at the end accordingly [1, 7, 4, 444] start ---" << endl;
     llist.insertAtTheEnd(1);
     llist.insertAtTheEnd(7);
     llist.insertAtTheEnd(4);
     llist.insertAtTheEnd(444);
-    cout << "--- Insert at the end accordingly [1, 7, 4, 444] end ---" << endl;
+    llist.insertAtTheFront(444);
+    llist.insertAtTheFront(444);
 
-    cout << "##########" << endl;
-    cout << "--- Print all nodes start ---" << endl;
     llist.printAllNodes();
-    cout << "---Print all nodes end ---" << endl;
-
-    cout << "##########" << endl;
-    cout << "--- Get number of nodes start ---" << endl;
-    cout << llist.getNumberOfNodes()<< endl;
-    cout << "--- Get number of nodes end ---" << endl;
-
-
-    cout << "##########" << endl;
-    cout << "--- print Reversed start ---" << endl;
-    llist.printReversed();
-    cout << "--- print Reversed end ---" << endl;
 
 
-    cout << "##########" << endl;
-    cout << "--- copy constructor start ---" << endl;
-    LinkedList<int> newList(llist);
-    cout << "---- created newList deep copying llist start ----" << endl;
-    newList.printAllNodes();
-    cout << "---- created newList deep copying llist endl ----" << endl;
-    cout << "---- Print all nodes of llist start ----" << endl;
-    llist.printAllNodes();
-    cout << "---Print all nodes of llist end ---" << endl;
-    cout << "---- changing llist and newList each ---" << endl;
-    llist.insertAtTheFront(6554);
-    newList.insertAtTheEnd(6677);
-    cout << "---- changed newList start ----" << endl;
-    newList.printAllNodes();
-    cout << "---- created newList endl ----" << endl;
-    cout << "---- llist start ----" << endl;
-    llist.printAllNodes();
-    cout << "---- llist end ---" << endl;
-    cout << "--- copy constructor end ---" << endl;
-
-    cout << "##########" << endl;
-    cout << "--- Remove node with data 4 from llist start ---" << endl;
-    llist.removeNode(llist.findNode(4));
-    llist.printAllNodes();
-    cout << "--- Remove node with data 4 from llist end ---" << endl;
+    // LinkedList<int> newList = llist;
 
 
-    cout << "##########" << endl;
-    cout << "------remove all nodes of llist start --------" << endl;
-    llist.removeAllNodes();
-    cout << llist.getNumberOfNodes()<< endl;
-    cout << "------remove all nodes of llist end --------" << endl;
-
-    cout << "##########" << endl;
-    cout << "--- insert after given node start ---" << endl;
-    cout << "--- before insertion 9000 after 4 ---" << endl;
-    newList.printAllNodes();
-    newList.insertAfterGivenNode(9000, newList.findNode(4));
-    cout << "--- after insertion 9000 after 4 ---" << endl;
-    newList.printAllNodes();
+    // llist.removeNode(llist.findNode(7));
+    // llist.removeAllNodes();
+    // llist.findNode(3);
+    // llist.printAllNodes();
 
+    
 
     return 0;
 }