Annotation for guarding routes

[nusje2000]

For ease of use, an annotation can be added that handles feature assertions. This should work something like this:

use Nusje2000\FeatureToggleBundle\Annotation as FeatureToggle;
// imports ...

/**
 * @Route("/some-route", name="route_name") # The symfony route definition
 *
 * @FeatureToggle\AssertEnabled() # Guard method
 * @FeatureToggle\AssertEnabled(route="route_name") # With route specification
 * @FeatureToggle\AssertEnabled(redirect="redirect_route_name") # With redirect route name
 * @FeatureToggle\AssertEnabled(redirect="/some/path") # With redirect path
 *
 * @FeatureToggle\AssertDisabled() # Guard method
 * @FeatureToggle\AssertDisabled(route="route_name") # With route specification
 * @FeatureToggle\AssertDisabled(redirect="redirect_route_name") # With redirect
 * @FeatureToggle\AssertDisabled(redirect="/some/path") # With redirect path
 */
public function someControllerMethod(): Response
{
    // ... code ...
}

[dbrekelmans]

Annotations would not cover cases where routes are defined in yaml or xml files.

It may be better to allow users to define an array of routes that should be guarded behind a feature toggle, for example:

nusje2000_feature_toggle:
    routes:
        some_feature_name:
            - 'some_route_name'
            - 'some_other_route_name'

You can use a kernel listener to check if symfony is requesting this route and throwing an AccessDenied exception. It's almost like the symfony firewall, except it checks the feature toggle instead of the user access.

[nusje2000]

@dbrekelmans that is indeed a good solution, however I still want to support the annotation. I will create a separate issue for this feature.

[nvdbeek]

@nusje2000 could we replace the annotation with attributes? Because PHP 8.0 has native support for this.

[nusje2000]

Yes, that seems like a good idea to me.