fix(nitro): resolve tracked externals #2743
Conversation
|
✔️ Deploy Preview for nuxt3-docs canceled. 🔨 Explore the source changes: 880c465 🔍 Inspect the deploy log: https://app.netlify.com/sites/nuxt3-docs/deploys/61e4a300a819b20007d1a6c7 |
It shouldn't be. Added the fix in vitest directly vitest-dev/vitest@e379f64 and released in v0.1.17 |
| @@ -58,7 +60,7 @@ export function externals (opts: NodeExternalsOptions): Plugin { | |||
| if (!resolved) { | |||
| console.warn(`Could not resolve \`${originalId}\`. Have you installed it?`) | |||
| } else { | |||
| trackedExternals.add(resolved.id) | |||
| trackedExternals.add(_require.resolve(resolved.id)) | |||
There was a problem hiding this comment.
require.resolve conditions are CommonmJS. This is not the best externalization policy IMO when we are using esm Imports (also nft can wrongly copy cjs build and import statement need to pick esm entry). See #1671 for the alternative attempt.
|
Is there any news about this PR? This is the only barrier to upgrading to Nuxt Bridge. |
|
Closing as this was the wrong approach. The issue to follow is nuxt/nuxt#12833. |
🔗 Linked issue
resolves nuxt/nuxt#12832, resolves nuxt/bridge#46
https://github.com/vercel/nft/blob/main/src/node-file-trace.ts#L33-L40
❓ Type of change
📚 Description
This PR resolves externals prior to adding to tracked files. @vercel/nft expects paths rather than module ids and would otherwise look for them in the root directory:
https://github.com/vercel/nft/blob/main/src/node-file-trace.ts#L33-L40
I've disabledoptimizeDepsin the fixture asvitestseems to be resolving to an optimised version when testing locally: is this intended behaviour @antfu?📝 Checklist