Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add component watchParam #1978

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add component watchParam #1978

wants to merge 1 commit into from

Conversation

Kolobok12309
Copy link

fix #1977
image
image

@netlify
Copy link

netlify bot commented Jan 9, 2022 •
edited
Loading

✔️ Deploy Preview for nuxt ready!

🔨 Explore the source changes: 675e5ac

🔍 Inspect the deploy log: https://app.netlify.com/sites/nuxt/deploys/61dafbba0bcdce0007fb7179

😎 Browse the preview: https://deploy-preview-1978--nuxt.netlify.app

@smarroufin smarroufin added the docs needs to be documented label Jan 10, 2022 — with Volta.net
@Uzere
Copy link

Uzere commented Jan 11, 2022

As I spent a lot of time figuring out what happens in nuxt/nuxt#10139, I would like to see watchParam menitioned on https://nuxtjs.org/docs/components-glossary/key#the-key-property because that is how one can get watchParam effect.
Also I think it would be good idea to explicitly menition when data() is called in https://nuxtjs.org/docs/concepts/nuxt-lifecycle#nuxt-lifecycle

@Kolobok12309
Copy link
Author

Kolobok12309 commented Jan 11, 2022 •
edited
Loading

@Uzere, Actually agree with you, unfortunately, I have no experience in graphic design and will not be able to update hooks.
Also i test behaviour when set watchParam: false and changed param and query, by source code i think this have bug and if true, this needs to be added to the documentation
UPD: If i set watchParam: false, watchQuery: true and change param AND query of route, nothing happens. Tests for it

Kolobok12309 added a commit to Kolobok12309/nuxt.js that referenced this pull request Jan 11, 2022
@Kolobok12309
Add tests to proof bug in nuxt/website-v2#1978
774446b 
nuxt/website-v2#1978 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atinux atinux Awaiting requested review from atinux atinux is a code owner

@danielroe danielroe Awaiting requested review from danielroe danielroe is a code owner

@pi0 pi0 Awaiting requested review from pi0 pi0 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
docs needs to be documented
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Doc] watchParam component property
3 participants
@Kolobok12309 @Uzere @smarroufin