Skip to content

Commit 5db817c

Browse files
committed
Reverted validation changes take 2
1 parent b5e5bfa commit 5db817c

File tree

3 files changed

+0
-70
lines changed

3 files changed

+0
-70
lines changed

src/Exceptions/DataConfigurationException.php

-6
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ class DataConfigurationException extends Exception
99
protected const int INVALID_BASE_SERIALIZERS = 10000;
1010

1111
protected const int INVALID_BASE_NORMALIZERS = 20000;
12-
protected const int INVALID_VALIDATION_CLASSES = 30000;
1312

1413
public static function invalidBaseSerializers(): self
1514
{
@@ -20,9 +19,4 @@ public static function invalidBaseNormalizers(): self
2019
{
2120
return new self('Invalid base normalizers', self::INVALID_BASE_NORMALIZERS);
2221
}
23-
24-
public static function invalidValidationClasses(): self
25-
{
26-
return new self('Invalid validation classes', self::INVALID_VALIDATION_CLASSES);
27-
}
2822
}

src/Exceptions/DataValidationException.php

-16
This file was deleted.

tests/Unit/DataConfigurationTest.php

-48
Original file line numberDiff line numberDiff line change
@@ -5,23 +5,16 @@
55
use Nuxtifyts\PhpDto\Configuration\DataConfiguration;
66
use Nuxtifyts\PhpDto\Configuration\NormalizersConfiguration;
77
use Nuxtifyts\PhpDto\Configuration\SerializersConfiguration;
8-
use Nuxtifyts\PhpDto\Configuration\ValidationConfiguration;
98
use Nuxtifyts\PhpDto\Exceptions\DataConfigurationException;
109
use Nuxtifyts\PhpDto\Normalizers\ArrayNormalizer;
11-
use Nuxtifyts\PhpDto\Support\Validation\ValidationRulesReferer;
12-
use Nuxtifyts\PhpDto\Support\Validation\Validator;
1310
use PHPUnit\Framework\Attributes\CoversClass;
1411
use PHPUnit\Framework\Attributes\Test;
15-
use PHPUnit\Framework\Attributes\UsesClass;
1612
use Throwable;
1713

1814
#[CoversClass(NormalizersConfiguration::class)]
1915
#[CoversClass(SerializersConfiguration::class)]
20-
#[CoversClass(ValidationConfiguration::class)]
2116
#[CoversClass(DataConfiguration::class)]
2217
#[CoversClass(DataConfigurationException::class)]
23-
#[UsesClass(Validator::class)]
24-
#[UsesClass(ValidationRulesReferer::class)]
2518
final class DataConfigurationTest extends UnitCase
2619
{
2720
/**
@@ -105,45 +98,4 @@ public function will_throw_an_exception_if_invalid_serializers_are_provided(): v
10598
],
10699
], forceCreate: true);
107100
}
108-
109-
/**
110-
* @throws Throwable
111-
*/
112-
#[Test]
113-
public function will_throw_an_exception_if_invalid_validator_is_provided(): void
114-
{
115-
self::expectException(DataConfigurationException::class);
116-
117-
DataConfiguration::getInstance([
118-
'validation' => [
119-
'validator' => 'invalidValidator',
120-
]
121-
], forceCreate: true);
122-
}
123-
124-
/**
125-
* @throws Throwable
126-
*/
127-
#[Test]
128-
public function will_throw_an_exception_if_invalid_rule_referer_is_provided(): void
129-
{
130-
self::expectException(DataConfigurationException::class);
131-
132-
DataConfiguration::getInstance([
133-
'validation' => [
134-
'ruleReferer' => 'invalidRuleReferer'
135-
]
136-
], forceCreate: true);
137-
}
138-
139-
/**
140-
* @throws Throwable
141-
*/
142-
public function will_provide_validation_configuration(): void
143-
{
144-
$config = DataConfiguration::getInstance(forceCreate: true);
145-
146-
self::assertTrue($config->validation->validatorClass === Validator::class);
147-
self::assertTrue($config->validation->validationRulesRefererClass === ValidationRulesReferer::class);
148-
}
149101
}

0 commit comments

Comments
 (0)