feat(#168): add prefixes #370
Conversation
BBboy01
changed the title
BBboy01
force-pushed
the
master
branch
3 times, most recently
from
0a281f8
to
896af6e
Compare
alex-courtis
changed the title
alex-courtis
changed the title
| {}, | ||
| icons_by_filename, | ||
| icons_by_file_prefix, | ||
| icons_by_file_extension, |
There was a problem hiding this comment.
I'm not sure we can do that - prefixes will clobber extensions, in this case "dockerfile".
There was a problem hiding this comment.
I've gone cold on this one; it's introducing breaking changes.
We need to refactor this change - specifically the API - such that existing behaviour does not change. For the user to return the prefix icon they will need to explicitly specify it.
Unfortunately we haven't used named parameters for all API methods however we cannot change that. options is available in some cases but not all.
Proposal:
Draft an API that preserves existing behaviour and allows prefixes to be selected.
Extension:
New API that uses all name parameters via options
| The name is passed in to check for an exact match e.g. `.bashrc` if there is no exact name match the extension | ||
| is used. Calls `.setup()` if it hasn't already ran. | ||
|
|
||
| ```lua | ||
| require'nvim-web-devicons'.get_icon(filename, extension, options) | ||
| require'nvim-web-devicons'.get_icon(filename, pre_or_ext, options) |
There was a problem hiding this comment.
This will break existing behaviour - a prefixed icon will be returned where none was before.
| else | ||
| icon_data = icons[name] or get_icon_by_extension(name, ext, opts) or (has_default and default_icon) | ||
| icon_data = icons[name] | ||
| or get_icon_by_prefix(name, pre_or_ext, opts) |
There was a problem hiding this comment.
This will result in a prefix being returned when users were previously expecting an extension, when the key is the same.
|
Please reopen if you wish to continue this change. |
Closes #168