Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highlight current scope - full buffer width? #12

Open
weilbith opened this issue Feb 3, 2021 · 4 comments · May be fixed by #31
Open

Highlight current scope - full buffer width? #12

weilbith opened this issue Feb 3, 2021 · 4 comments · May be fixed by #31
Labels
enhancement New feature or request

Comments

@weilbith
Copy link

weilbith commented Feb 3, 2021

Is your feature request related to a problem? Please describe.
I like the idea of having the current scope highlighted. But I must admit that I get "annoyed" that only the texts background changes. So depending on the different lines length and empty lines etc this just looks ugly in my very personal opinion.

Describe the solution you'd like
The highlight applies to the full line for the whole length of the buffer like the cursorline does.
I'm afraid that is not simply possible from the current highlight API...

Describe alternatives you've considered
Well, just disable the current scope highlight...

Additional context
🤷
@weilbith weilbith added the enhancement New feature or request label Feb 3, 2021
@theHamsta
Copy link
Member

My original idea was to dim non-current-scope text a bit, at least this should be possible now.

@weilbith weilbith mentioned this issue Mar 1, 2021
Merged
14 tasks
@pwntester
Copy link

Came here from pwntester/octo.nvim#105

There is a workaround to apply a highlight to the whole window-width line (including EOL space). You can define a sign and apply a linehl group such as in:

sign define octo_comment text=❯ texthl=OctoNvimCommentLine linehl=OctoNvimCommentLine

not sure if this helps here though 🤷🏻

@weilbith
Copy link
Author

weilbith commented Mar 1, 2021

Do sign highlights sum up? Let's say I have a LSP diagnostic error in my current scope. This LSP sign has no linhehl but only a text. Would I then still have the background color of the lower prio sign from current scope? Sorry if that reads confusing. I should just try it out myself...

@pwntester
Copy link

Im not sure, I guess the best way to figure it out is try adding two signs on the same line with different hl options

@JafarAbdi JafarAbdi linked a pull request Mar 26, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
3 participants
@pwntester @theHamsta @weilbith