Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10-bit presentation looks wrong on radv #46

Open
airlied opened this issue May 30, 2023 · 4 comments
Open

10-bit presentation looks wrong on radv #46

airlied opened this issue May 30, 2023 · 4 comments

Comments

@airlied
Copy link

airlied commented May 30, 2023

I'm seeing what looks like maybe 8-bit sampling from 10-bit data or something when testing HEVC 10-bit content.

Does it work okay on nvidia?

@airlied
Copy link
Author

airlied commented May 30, 2023

I wonder is this because I'm just running in an 24-bit X server

@airlied
Copy link
Author

airlied commented May 30, 2023

I just tried a depth 30 X session, but still seeing a red tint over the whole video.

@airlied
Copy link
Author

airlied commented May 30, 2023

okay this looks like radv doesn't offer ycbcr sampling on the format, I should probably investigate fixing that first.

@zlatinski
Copy link
Contributor

Hi Dave,

Please also check the m_samplerYcbcrModelConversion and m_samplerYcbcrRange in VulkanFrame::DrawFrame(). Currently, the app has it fixed to BT709 NARROW range, but this should reflect the settings from the compressed content. Most of the 10/12-bit content uses BT2020 with full range. So, your colors can look off.
I'll fix the app to handle this correctly, soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants