Add number disambiguation endpoint #805
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #805 +/- ##
==========================================
+ Coverage 94.88% 94.93% +0.05%
==========================================
Files 89 91 +2
Lines 3809 3852 +43
==========================================
+ Hits 3614 3657 +43
Misses 195 195 ☔ View full report in Codecov by Sentry. |
WillNilges
reviewed
Jan 16, 2025
|
|
||
| # TODO: Fix docs, maybe with custom install serializer? | ||
| class DisambiguateInstallOrNetworkNumber(APIView): | ||
| permission_classes = [HasDisambiguateNumberPermission] |
There was a problem hiding this comment.
What do you think about just letting anyone with read-only role or better use this instead of making a permission? Is there a service that needs least privilege?
| if install_object and install_object.status == Install.InstallStatus.NN_REASSIGNED | ||
| else None | ||
| ), | ||
| "exact_match_nonrecycled_install": ( |
There was a problem hiding this comment.
Nit, I think it would be clearer to have exact_match_install:
Suggested change
| "exact_match_nonrecycled_install": ( | |
| "exact_match_install": ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new API endpoint which aids in network/install number disambiguation. Given an ambiguous number, checks if it matches the NN for an existing node, and returns that node. If not, checks the given number as an install number and returns the attached node (if it exists).
Also returns fields to "show its work", which let you see what objects it found matching the requested number
Closes #801