Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Support for Custom Ports #120

Closed
OmarAssadi opened this issue Oct 13, 2017 · 10 comments · Fixed by #129
Closed

Support for Custom Ports #120

OmarAssadi opened this issue Oct 13, 2017 · 10 comments · Fixed by #129

Comments

@OmarAssadi
Copy link

OmarAssadi commented Oct 13, 2017

Hey!

It would be great if someone could add support for non-standard ports when configuring an email account. In my particular case, it makes it mildly annoying to use ProtonMail as their bridge software defaults to 1143 and 1025 for the incoming/outgoing ports.

Also, this affects signifcantly more people than simply ProtonMail users. Many organizations change their mail server ports—which makes Nylas unusable without using inspect element or something. See: nylas/nylas-mail#3424

@OmarAssadi
Copy link
Author

Added a small bounty: current bounty

@OmarAssadi
Copy link
Author

Pinging @axelvnk - Hey! I saw that you made a pull request on the main Nylas Mail repository (nylas/nylas-mail#3640). It doesn't appear that there is any real activity there, though.

Figured I'd see if you would like to make that pull request here before I go ahead and make my own.

@axelvnk
Copy link

axelvnk commented Oct 16, 2017

@54 I'll do it tonight :)

@kaustav1996
Copy link

@axelvnk did you do it?

@mikeseese
Copy link
Contributor

@dweremeichik would you want this to remove the dropdown in place of a text field for port number? Or would we rather have the dropdown with "Custom..." which shows the input field and allows for input? The latter I think is better, but will require some extra work

@dweremeichik
Copy link
Member

I'm behind the latter. The other option allows for too much error. It's hard enough for most to set up email as it is.
To be honest there has been times when I have forgotten which port my provider used in the past, simple solution was to try each available option. Can't do that with a text box.

@mikeseese
Copy link
Contributor

mikeseese commented Oct 25, 2017

agreed; therefore i dont think the PR at nylas/nylas-mail#3640 is sufficient. i've got some time tonight to work this. still need my 4 PRs for the month >.>

that is if @axelvnk doesnt want to work it

@mikeseese
Copy link
Contributor

i went ahead and started this

@mikeseese mikeseese self-assigned this Oct 26, 2017
@mikeseese
Copy link
Contributor

Here's what it looks like:

peek 2017-10-25 23-20

@dweremeichik
Copy link
Member

Well done! I'm 👍 on this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants