Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error if using addon in Ember 4.x #111

Open
BwehaaFox opened this issue Feb 18, 2022 · 1 comment
Open

Error if using addon in Ember 4.x #111

BwehaaFox opened this issue Feb 18, 2022 · 1 comment

Comments

@BwehaaFox
Copy link

BwehaaFox commented Feb 18, 2022

When using this addon in Ember 4.x, an error occurs when trying to play sound. The main problem is removing Ember global and removing getWithDefault.

The ember-poll service does not compile correctly in the ember-poll addon. Service.extend compiles to Ember.Service.extend which causes an error when using this addon.

This addon uses getWithDefault which was removed in Ember 4.x

Also ember-copy in this addon also causes an error. Fix upgrading to ember-copy to version 2.0.1

I made an attempt to fork both addons, raise dependencies and write getWithDefault based on the original method locally, but later the internal logic of this addon began to fail, in particular calling PromiseRace.start when calling the callback and trying to read strategy.connection in which strategy became undefined which causes a crash when trying to play a sound.

At the same time, when downgrading ember-source to 3.28 and installing original addons, the problem disappears completely.

Alas, I do not have the opportunity to thoroughly study the work of this addon from the inside and make more correct corrections other than the poke method, so I ask people who know who are involved in this addon to add support for Ember 4.x

@jkeen
Copy link
Contributor

jkeen commented Feb 19, 2022

Unfortunately hifi doesn't work with the latest ember, and is pretty old school in terms of modern ember paradigms.

However it's modern successor ember-stereo should work just fine with 4.0 and is way easier to deal with overall! I spent a lot of time rethinking the interface, resolving some longstanding issues with hifi, and most crucially adding interactive documentation. Check it out and file an issue on that repo if things don't work right for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants