Skip to content

Conversation

@Shigoto-dev19
Copy link

@Shigoto-dev19 Shigoto-dev19 commented Nov 5, 2025

Addresses: o1-labs/o1js#2483 & o1-labs/o1js#2485

o1js side: o1-labs/o1js#2633
mina side: MinaProtocol/mina#18115

Blocked by o1-labs/o1js#2493 as it depends on WasmProverProof napi conversion. (In Review: #3371)

Doesn't require napi conversion for:

  • fp_oracles_create_no_public
  • fq_oracles_create_no_public

These functions already skip NAPI conversion on the WASM side because they invoke {fp, fq}_oracles_create in the Kimchi bindings with empty public inputs.

Note: The diff is bigger because I merged that latest changes from native/napi branch but the main changes are in plonk-napi/oracles.rs.
This ☝️ happened because I merged native/napi into shigoto/native/napi/oracles instead of native/napi-gatevector.

@Shigoto-dev19 Shigoto-dev19 changed the base branch from master to native/napi-gatevector November 5, 2025 10:54
@Shigoto-dev19 Shigoto-dev19 force-pushed the shigoto/native/napi/oracles branch from 6d389ce to d198659 Compare November 5, 2025 13:55
Base automatically changed from native/napi-gatevector to native/napi November 6, 2025 10:38
@Shigoto-dev19 Shigoto-dev19 force-pushed the shigoto/native/napi/oracles branch from d198659 to c2464c9 Compare November 13, 2025 19:21
@Shigoto-dev19 Shigoto-dev19 changed the base branch from native/napi to shigoto/native/napi/proof-types-conversion November 13, 2025 19:22
Base automatically changed from shigoto/native/napi/proof-types-conversion to querolita/napi-proof November 14, 2025 14:00
@querolita querolita self-assigned this Nov 17, 2025
@querolita querolita marked this pull request as ready for review November 20, 2025 20:33
@querolita
Copy link
Member

I merged the latest version of querolita/napi-proof on this branch and executed the same tests. The native workflow fails exactly at the same place -> now blocked on verifier index stuff (this will be the upcoming big PR set). Thus, I am merging into that branch given that this one only is 1 commit long. The diff is +300, but I will point to the reviewers of #3368 to the diff of only the PR-related commits.

@querolita querolita merged commit 261d047 into querolita/napi-proof Nov 20, 2025
21 of 26 checks passed
@querolita querolita deleted the shigoto/native/napi/oracles branch November 20, 2025 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants