Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: o1-labs/o1js#2483 & o1-labs/o1js#2485
o1js side: o1-labs/o1js#2633
mina side: MinaProtocol/mina#18115
Blocked by o1-labs/o1js#2493 as it depends onWasmProverProofnapi conversion. (In Review: #3371)Doesn't require napi conversion for:
fp_oracles_create_no_publicfq_oracles_create_no_publicThese functions already skip NAPI conversion on the WASM side because they invoke
{fp, fq}_oracles_createin the Kimchi bindings with empty public inputs.Note: The diff is bigger because I merged that latest changes fromnative/napibranch but the main changes are inplonk-napi/oracles.rs.This ☝️ happened because I merged
native/napiintoshigoto/native/napi/oraclesinstead ofnative/napi-gatevector.