Skip to content

Specify how entities returned by $compute are explicitly included in the response #2059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Apr 9, 2025
Merged

Specify how entities returned by $compute are explicitly included in the response #2059

merged 16 commits into from
Apr 9, 2025

Conversation

ralfhandl
Copy link
Contributor

@ralfhandl ralfhandl commented Mar 3, 2025 •
edited
Loading

Fixes #2047
Fixes #2063

HeikoTheissen
HeikoTheissen requested changes Mar 3, 2025
View reviewed changes
mikepizzo
mikepizzo reviewed Mar 12, 2025
View reviewed changes
@ralfhandl ralfhandl force-pushed the 2047-entities-returned-by-compute branch from bf18ace to 4a634f1 Compare March 19, 2025 16:28
@ralfhandl ralfhandl requested a review from mikepizzo March 19, 2025 16:28
HeikoTheissen
HeikoTheissen previously approved these changes Mar 26, 2025
View reviewed changes
@HeikoTheissen HeikoTheissen dismissed their stale review March 26, 2025 15:24

Raise an error if it can be determined from the type that $expand is not allowed.

mikepizzo
mikepizzo requested changes Mar 26, 2025
View reviewed changes
Copy link
Contributor

@mikepizzo mikepizzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would expect that, if the type of the expression is deterministic (i.e., price mult quantity) then it must be used appropriately. If the type type of the expression is non-deterministic, then it is ignored in $expand.

ralfhandl
ralfhandl commented Mar 27, 2025
View reviewed changes
HeikoTheissen
HeikoTheissen previously approved these changes Apr 9, 2025
View reviewed changes
mikepizzo
mikepizzo reviewed Apr 9, 2025
View reviewed changes
@mikepizzo mikepizzo merged commit 428d2a9 into main Apr 9, 2025
1 check passed
@mikepizzo mikepizzo deleted the 2047-entities-returned-by-compute branch April 9, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikepizzo mikepizzo mikepizzo approved these changes

@HeikoTheissen HeikoTheissen HeikoTheissen left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add more information on dynamic properties Specify how entities returned by $compute are explicitly included in the response
3 participants
@ralfhandl @mikepizzo @HeikoTheissen