Skip to content

Doesn't fully hide dialog element (breaks nature.com, link.springer.com, biomedcentral.com etc...) #282

@moddular

Description

@moddular

The cookie banner on nature.com link.springer.com etc... gets hidden I suspect because it matches the .cc-banner selector from https://github.com/oblador/hush/blob/master/data/vendor/fanboy-cookiemonster.txt

However, because the banner is a dialog element setting it as display: none only hides the content of the banner and still leaves the Top Layer created by the dialog covering the page and preventing any clicks from working.

I think the correct handling for a dialog might be to trigger it's close method instead of setting the display?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions