-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate benchmarks to criterion #14
Comments
I've used Criterion in a few places before. The reason I haven't used it here is that it seems to take a very long time to run by default, while the Maybe you can suggest some non-default parameters for Criterion that would make it run faster? But I don't know enough about the crate to know what to try. |
I guess something like this should help: criterion_group! {
name = bench_multiprocess;
config = dont_take_an_eternity_to_run();
targets = blake2b_hash_many,
hash_sneves_blake2sp,
openssl_sha1,
}
criterion_main!(bench_multiprocess);
fn dont_take_an_eternity_to_run() -> Criterion {
Criterion::default().nresamples(1_000)
.without_plots()
.sample_size(10)
} For more options see https://bheisler.github.io/criterion.rs/criterion/struct.Criterion.html |
I'd be happy to take a pull request for this as long as we could keep the total benchmarking time under, say, 200% of what it is now. |
https://github.com/bheisler/criterion.rs compiles on rust stable, meaning you can
cargo check --benches
in your CI to catch accidentally broken benches. You also get charts and statistics for free.The text was updated successfully, but these errors were encountered: