-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Last version has silently force-bumped MSRV without breaking change #30
Comments
This was mentioned in the release notes: https://github.com/oconnor663/blake2_simd/releases/tag/1.0.2. The bump was discussed here: #29 (comment). But I realize that in your shoes that's hardly different from "silent". This crate doesn't have an explicit MSRV policy, but if it did it would probably be similar to this proposed policy from
Is there a specific "stable - N" policy you aim to support? |
That's my bad, I should have checked the release notes. I did not. Thanks for the links!
That makes a lot of sense. I was unaware of it! I like the N-2, N-3 policy they propose. Definitely makes sense and also doesn't fight against semver which seems also the way to go. I don't have any specific proposals, neither know what would make more sense (2,3 etc..). So happy with any that you feel makes sense. So that we can follow it! :) Thanks so much for the detailed and quick response. |
We can also close this probably @oconnor663 ?? Again thanks a lot for the references! |
I'd suggest to add an MSRV to the crate in the next release. And keep track of what bumps or not the MSRV. As basically anyone that has MSRV and builds on the top of this lib gets the CI crushed every time a new dependency is silently bumping the MSRV without you noticing (as you depend on things with
"^0.x.x"
.For more info, see: privacy-scaling-explorations/halo2#207
The text was updated successfully, but these errors were encountered: