[IMP] project,hr_timesheet: handle AA cases

When a project template is created not converted we should not create a AA.

task-4700744

Author: kthe-odoo

addons/hr_timesheet/models/project_project.py

@@ -100,7 +100,7 @@ def _search_is_project_overtime(self, operator, value):
     @api.constrains('allow_timesheets', 'account_id')
     def _check_allow_timesheet(self):
         for project in self:
-            if project.allow_timesheets and not project.account_id:
+            if project.allow_timesheets and not project.account_id and not project.is_template:
                 project_plan, _other_plans = self.env['account.analytic.plan']._get_all_plans()
                 raise ValidationError(_(
                     "To use the timesheets feature, you need an analytic account for your project. Please set one up in the plan '%(plan_name)s' or turn off the timesheets feature.",
@@ -135,12 +135,12 @@ def create(self, vals_list):
         """ Create an analytic account if project allow timesheet and don't provide one
             Note: create it before calling super() to avoid raising the ValidationError from _check_allow_timesheet
         """
-        defaults = self.default_get(['allow_timesheets', 'account_id'])
+        defaults = self.default_get(['allow_timesheets', 'account_id', 'is_template'])
         analytic_accounts_vals = [
             vals for vals in vals_list
             if (
                 vals.get('allow_timesheets', defaults.get('allow_timesheets')) and
-                not vals.get('account_id', defaults.get('account_id'))
+                not vals.get('account_id', defaults.get('account_id')) and not vals.get('is_template', defaults.get('is_template'))
             )
         ]
 
@@ -153,7 +153,7 @@ def create(self, vals_list):
     def write(self, values):
         # create the AA for project still allowing timesheet
         if values.get('allow_timesheets') and not values.get('account_id'):
-            project_wo_account = self.filtered(lambda project: not project.account_id)
+            project_wo_account = self.filtered(lambda project: not project.account_id and not project.is_template)
             if project_wo_account:
                 project_wo_account._create_analytic_account()
         return super().write(values)
@@ -171,7 +171,7 @@ def _compute_display_name(self):
 
     @api.model
     def _init_data_analytic_account(self):
-        self.search([('account_id', '=', False), ('allow_timesheets', '=', True)])._create_analytic_account()
+        self.search([('account_id', '=', False), ('allow_timesheets', '=', True), ('is_template', '=', False)])._create_analytic_account()
 
     @api.ondelete(at_uninstall=False)
     def _unlink_except_contains_entries(self):
@@ -283,3 +283,8 @@ def action_view_tasks(self):
         action = super().action_view_tasks()
         action['context']['allow_timesheets'] = self.allow_timesheets
         return action
+
+    def action_create_from_template(self, values=None):
+        project = super().action_create_from_template(values)
+        project._create_analytic_account()
+        return project

addons/hr_timesheet/tests/__init__.py

@@ -5,3 +5,4 @@
 from . import test_project_task_quick_create
 from . import test_portal_timesheet
 from . import test_project_project
+from . import test_project_template

addons/hr_timesheet/tests/test_project_template.py

@@ -0,0 +1,34 @@
+from odoo.tests import TransactionCase, tagged
+
+
+@tagged('post_install', '-at_install')
+class TestProjectProjectTemplate(TransactionCase):
+
+    def test_template_created_not_having_analytic_account(self):
+        template_project, normal_project = self.env["project.project"].create(
+            [
+                {
+                    "name": "Template Project",
+                    "is_template": True,
+                    "allow_timesheets": True,
+                },
+                {
+                    "name": "Normal Project",
+                    "is_template": False,
+                    "allow_timesheets": True,
+                },
+            ]
+        )
+
+        self.assertFalse(template_project.account_id, "The template project shouldn't have analytic account")
+        self.assertTrue(normal_project.account_id, "A normal project should have a analytic account")
+
+    def test_project_created_from_template_to_have_analytic_account(self):
+        template_project = self.env['project.project'].create({
+            "name": "Template Project",
+            "is_template": True,
+            "allow_timesheets": True,
+        })
+
+        new_project = template_project.action_create_from_template()
+        self.assertTrue(new_project.account_id, "A project created from template should have a analytic account")