[IMP] project,*: added project templates mechanism

* = hr_timesheet, sale_project, project_purchase, project_mrp, project_stock,
sale_timesheet, website_project, analytic, project_timesheet_holidays

In this PR we add Project templates which will contribute towards template
system in the Project app. Reusable project templates to work.

task-4700744

Co-authored-by: Maxime de Neuville <[email protected]>
Co-authored-by: Prakash Prajapati <[email protected]>

Author: 3 people

addons/hr_timesheet/__init__.py

@@ -36,7 +36,7 @@ def _uninstall_hook(env):
     def update_action_window(xmlid):
         act_window = env.ref(xmlid, raise_if_not_found=False)
         if act_window and act_window.domain and 'is_internal_project' in act_window.domain:
-            act_window.domain = []
+            act_window.domain = [("is_template", "=", False)]
 
     update_action_window('project.open_view_project_all')
     update_action_window('project.open_view_project_all_group_stage')

addons/hr_timesheet/models/hr_timesheet.py

@@ -45,7 +45,7 @@ def default_get(self, field_list):
         return result
 
     def _domain_project_id(self):
-        domain = [('allow_timesheets', '=', True)]
+        domain = [('allow_timesheets', '=', True), ('is_template', '=', False)]
         if not self.env.user.has_group('hr_timesheet.group_timesheet_manager'):
             return expression.AND([domain,
                 ['|', ('privacy_visibility', '!=', 'followers'), ('message_partner_ids', 'in', [self.env.user.partner_id.id])]

addons/hr_timesheet/models/project_project.py

@@ -100,7 +100,7 @@ def _search_is_project_overtime(self, operator, value):
     @api.constrains('allow_timesheets', 'account_id')
     def _check_allow_timesheet(self):
         for project in self:
-            if project.allow_timesheets and not project.account_id:
+            if project.allow_timesheets and not project.account_id and not project.is_template:
                 project_plan, _other_plans = self.env['account.analytic.plan']._get_all_plans()
                 raise ValidationError(_(
                     "To use the timesheets feature, you need an analytic account for your project. Please set one up in the plan '%(plan_name)s' or turn off the timesheets feature.",
@@ -135,12 +135,12 @@ def create(self, vals_list):
         """ Create an analytic account if project allow timesheet and don't provide one
             Note: create it before calling super() to avoid raising the ValidationError from _check_allow_timesheet
         """
-        defaults = self.default_get(['allow_timesheets', 'account_id'])
+        defaults = self.default_get(['allow_timesheets', 'account_id', 'is_template'])
         analytic_accounts_vals = [
             vals for vals in vals_list
             if (
                 vals.get('allow_timesheets', defaults.get('allow_timesheets')) and
-                not vals.get('account_id', defaults.get('account_id'))
+                not vals.get('account_id', defaults.get('account_id')) and not vals.get('is_template', defaults.get('is_template'))
             )
         ]
 
@@ -153,7 +153,7 @@ def create(self, vals_list):
     def write(self, values):
         # create the AA for project still allowing timesheet
         if values.get('allow_timesheets') and not values.get('account_id'):
-            project_wo_account = self.filtered(lambda project: not project.account_id)
+            project_wo_account = self.filtered(lambda project: not project.account_id and not project.is_template)
             if project_wo_account:
                 project_wo_account._create_analytic_account()
         return super().write(values)
@@ -171,7 +171,7 @@ def _compute_display_name(self):
 
     @api.model
     def _init_data_analytic_account(self):
-        self.search([('account_id', '=', False), ('allow_timesheets', '=', True)])._create_analytic_account()
+        self.search([('account_id', '=', False), ('allow_timesheets', '=', True), ('is_template', '=', False)])._create_analytic_account()
 
     @api.ondelete(at_uninstall=False)
     def _unlink_except_contains_entries(self):
@@ -283,3 +283,8 @@ def action_view_tasks(self):
         action = super().action_view_tasks()
         action['context']['allow_timesheets'] = self.allow_timesheets
         return action
+
+    def action_create_from_template(self, values=None):
+        project = super().action_create_from_template(values)
+        project._create_analytic_account()
+        return project

addons/hr_timesheet/models/project_task.py

@@ -29,7 +29,7 @@
 class ProjectTask(models.Model):
     _inherit = "project.task"
 
-    project_id = fields.Many2one(domain="['|', ('company_id', '=', False), ('company_id', '=?',  company_id), ('is_internal_project', '=', False)]")
+    project_id = fields.Many2one(domain="['|', ('company_id', '=', False), ('company_id', '=?',  company_id), ('is_internal_project', '=', False), ('is_template', 'in', [is_template, False])]")
     analytic_account_active = fields.Boolean("Active Analytic Account", related='project_id.analytic_account_active', export_string_translation=False)
     allow_timesheets = fields.Boolean(
         "Allow timesheets",

addons/hr_timesheet/models/res_company.py

@@ -24,8 +24,10 @@ def _default_timesheet_encode_uom_id(self):
     timesheet_encode_uom_id = fields.Many2one('uom.uom', string="Timesheet Encoding Unit",
         default=_default_timesheet_encode_uom_id)
     internal_project_id = fields.Many2one(
-        'project.project', string="Internal Project",
-        help="Default project value for timesheet generated from time off type.")
+        "project.project", string="Internal Project",
+        domain=[("is_template", "=", False)],
+        help="Default project value for timesheet generated from time off type.",
+    )
 
     @api.constrains('internal_project_id')
     def _check_internal_project_id_company(self):

addons/hr_timesheet/tests/__init__.py

@@ -5,3 +5,4 @@
 from . import test_project_task_quick_create
 from . import test_portal_timesheet
 from . import test_project_project
+from . import test_project_template

addons/hr_timesheet/tests/test_project_template.py

@@ -0,0 +1,34 @@
+from odoo.tests import TransactionCase, tagged
+
+
+@tagged('post_install', '-at_install')
+class TestProjectProjectTemplate(TransactionCase):
+
+    def test_template_created_not_having_analytic_account(self):
+        template_project, normal_project = self.env["project.project"].create(
+            [
+                {
+                    "name": "Template Project",
+                    "is_template": True,
+                    "allow_timesheets": True,
+                },
+                {
+                    "name": "Normal Project",
+                    "is_template": False,
+                    "allow_timesheets": True,
+                },
+            ]
+        )
+
+        self.assertFalse(template_project.account_id, "The template project shouldn't have analytic account")
+        self.assertTrue(normal_project.account_id, "A normal project should have a analytic account")
+
+    def test_project_created_from_template_to_have_analytic_account(self):
+        template_project = self.env['project.project'].create({
+            "name": "Template Project",
+            "is_template": True,
+            "allow_timesheets": True,
+        })
+
+        new_project = template_project.action_create_from_template()
+        self.assertTrue(new_project.account_id, "A project created from template should have a analytic account")

addons/hr_timesheet/views/project_project_views.xml

@@ -23,7 +23,7 @@
             <field name="arch" type="xml">
                 <xpath expr="//header" position="after">
                     <field name="analytic_account_active" invisible="1"/>
-                    <t name="timesheet_error" invisible="not allow_timesheets">
+                    <t name="timesheet_error" invisible="not allow_timesheets or is_template">
                         <div class="alert alert-warning mb-1 text-center" role="alert" colspan="2" invisible="not account_id or analytic_account_active">
                             You cannot log timesheets on this project since it is linked to an inactive analytic account.<br/>
                             Please switch to another account, or reactivate the current one to timesheet on the project.
@@ -77,7 +77,7 @@
                     <field name="allocated_hours"/>
                 </xpath>
                 <xpath expr="//div[@name='card_menu_view']" position="inside">
-                    <div role="menuitem" t-if="record.allow_timesheets.raw_value" groups="hr_timesheet.group_hr_timesheet_user">
+                    <div role="menuitem" t-if="record.allow_timesheets.raw_value and !record.is_template.raw_value" groups="hr_timesheet.group_hr_timesheet_user">
                         <a name="action_project_timesheets" type="object">Timesheets</a>
                     </div>
                 </xpath>
@@ -86,7 +86,7 @@
                     <t t-set="badgeColor" t-value="'border-danger'" t-if="record.remaining_hours.raw_value &lt; 0"/>
                     <t t-set="title" t-if="record.encode_uom_in_days.raw_value">Days Remaining</t>
                     <t t-set="title" t-else="">Time Remaining</t>
-                    <div t-if="record.allow_timesheets.raw_value and record.allocated_hours.raw_value &gt; 0"
+                    <div t-if="!record.is_template.raw_value and  record.allow_timesheets.raw_value and record.allocated_hours.raw_value &gt; 0"
                         t-attf-class="me-1 ms-1 bg-transparent badge border {{ badgeColor }}" t-att-title="title" groups="hr_timesheet.group_hr_timesheet_user">
                         <field name="remaining_hours" widget="timesheet_uom" class="p-0"/>
                     </div>
@@ -100,17 +100,28 @@
             <field name="inherit_id" ref="project.view_project_project_filter"/>
             <field name="arch" type="xml">
                 <filter name="late_milestones" position="before">
-                    <filter string="Timesheets &gt;100%" name="projects_in_overtime" domain="[('is_project_overtime', '=', True)]" groups="project.group_project_manager"/>
+                    <filter string="Timesheets &gt;100%" name="projects_in_overtime" domain="[('is_project_overtime', '=', True)]" groups="project.group_project_manager" invisible="context.get('default_is_template')"/>
                 </filter>
             </field>
         </record>
 
         <record id="project.open_view_project_all" model="ir.actions.act_window">
-            <field name="domain">[('is_internal_project', '=', False)]</field>
+            <field name="domain">[('is_internal_project', '=', False), ("is_template", "=", False)]</field>
         </record>
 
         <record id="project.open_view_project_all_group_stage" model="ir.actions.act_window">
-            <field name="domain">[('is_internal_project', '=', False)]</field>
+            <field name="domain">[('is_internal_project', '=', False), ("is_template", "=", False)]</field>
+        </record>
+
+        <!-- Project Template  -->
+        <record id="project_templates_view_list_inherit_timesheet" model="ir.ui.view">
+            <field name="name">project.project.template.list.inherit.timesheet</field>
+            <field name="model">project.project</field>
+            <field name="inherit_id" ref="project.project_templates_view_list"/>
+            <field name="arch" type="xml">
+                <field name="effective_hours" position="replace"/>
+                <field name="remaining_hours" position="replace"/>
+            </field>
         </record>
     </data>
 </odoo>