[FIX] hr_attendance: count lunch intervals in attendance auto check out

**Issue**
For example, in the case of a working schedule from 8:00 to 17:00 with
a 1 hour lunch period, 8 hours of work are expected. By taking the
lunch interval into account, the auto check out will happen at 17:00
if the company's tolerance in the attendance's setting is set at 0.
Previously, it would happen at 16:00, resulting in only 7 worked hours
for the attendance while the user may expect the attendance's worked
hours to match the expected working hours of the schedule.

**Solution**
- include lunch attendances (not taken into account by `duration_hours`)
in the total time that needs to be exceeded before an `hr.attendance` is
automatically checked out.
Note that this solution manages the case where `hr.attendance` are outside
lunch periods (e.g. 8-12 and 13-17, but no attendance between 12-13). Though
in that case, the automatic check out will be delayed by at least 1h.

Note: a change was also made to account for 2 weeks calendars.

opw-4402321

closes odoo#210921

X-original-commit: 179c043
Signed-off-by: Tanguy Quéguineur (taqu) <[email protected]>
Signed-off-by: Bertrand Dossogne (bedo) <[email protected]>

Author: taqu-odoo

addons/hr_attendance/models/hr_attendance.py

@@ -709,14 +709,16 @@ def _cron_auto_check_out(self):
             max_tol = company.auto_check_out_tolerance
             to_verify_company = to_verify.filtered(lambda a: a.employee_id.company_id.id == company.id)
 
-            # Attendances where Last open attendance worked time + previously worked time on that day + tolerance greater than the planned worked hours in his calendar
-            to_check_out = to_verify_company.filtered(lambda a: (fields.Datetime.now() - a.check_in).seconds / 3600 + mapped_previous_duration[a.employee_id][a.check_in.date()] - max_tol > (sum(a.employee_id.resource_calendar_id.attendance_ids.filtered(lambda att: att.dayofweek == str(a.check_in.weekday())).mapped('duration_hours'))))
+            # Attendances where Last open attendance time + previously worked time on that day + tolerance greater than the attendances hours (including lunch) in his calendar
+            to_check_out = to_verify_company.filtered(lambda a: (fields.Datetime.now() - a.check_in).seconds / 3600 + mapped_previous_duration[a.employee_id][a.check_in.date()] - max_tol > (sum(a.employee_id.resource_calendar_id.attendance_ids.filtered(lambda att: att.dayofweek == str(a.check_in.weekday()) and (not att.two_weeks_calendar or att.week_type == str(att.get_week_type(a.check_in.date())))).mapped(lambda at: at.hour_to - at.hour_from))))
             body = _('This attendance was automatically checked out because the employee exceeded the allowed time for their scheduled work hours.')
 
             for att in to_check_out:
-                delta_duration = max(1, (sum(att.employee_id.resource_calendar_id.attendance_ids.filtered(lambda a: a.dayofweek == str(att.check_in.weekday())).mapped('duration_hours')) + max_tol - mapped_previous_duration[att.employee_id][att.check_in.date()]) * 3600)
+                expected_worked_hours = sum(att.employee_id.resource_calendar_id.attendance_ids.filtered(lambda a: a.dayofweek == str(att.check_in.weekday()) and (not a.two_weeks_calendar or a.week_type == str(a.get_week_type(att.check_in.date())))).mapped("duration_hours"))
+                att.check_out = fields.Datetime.now()
+                excess_hours = att.worked_hours - (expected_worked_hours + max_tol - mapped_previous_duration[att.employee_id][att.check_in.date()])
                 att.write({
-                    "check_out": att.check_in + relativedelta(seconds=delta_duration),
+                    "check_out": max(att.check_out - relativedelta(hours=excess_hours), att.check_in + relativedelta(seconds=1)),
                     "out_mode": "auto_check_out"
                 })
                 att.message_post(body=body)

addons/hr_attendance/tests/test_hr_attendance_overtime.py

@@ -418,11 +418,17 @@ def test_auto_check_out(self):
             'auto_check_out': True,
             'auto_check_out_tolerance': 1
         })
-        self.env['hr.attendance'].create({
+        self.env['hr.attendance'].create([{
             'employee_id': self.employee.id,
             'check_in': datetime(2024, 2, 1, 8, 0),
+            'check_out': datetime(2024, 2, 1, 11, 0)
+        },
+        {
+            'employee_id': self.employee.id,
+            'check_in': datetime(2024, 2, 1, 11, 0),
             'check_out': datetime(2024, 2, 1, 13, 0)
-        })
+        }
+        ])
 
         attendance_utc_pending = self.env['hr.attendance'].create({
             'employee_id': self.employee.id,
@@ -467,6 +473,56 @@ def test_auto_check_out(self):
         # Employee with flexible working schedule should not be checked out
         self.assertEqual(attendance_flexible_pending.check_out, False)
 
+    def test_auto_check_out_lunch_period(self):
+        Attendance = self.env['hr.attendance']
+        self.company.write({
+            'auto_check_out': True,
+            'auto_check_out_tolerance': 1
+        })
+        morning, afternoon = Attendance.create([{
+            'employee_id': self.employee.id,
+            'check_in': datetime(2024, 1, 1, 8, 0),
+            'check_out': datetime(2024, 1, 1, 12, 0)
+        },
+        {
+            'employee_id': self.employee.id,
+            'check_in': datetime(2024, 1, 1, 13, 0)
+        }])
+
+        with freeze_time("2024-01-01 22:00:00"):
+            Attendance._cron_auto_check_out()
+            self.assertEqual(morning.worked_hours + afternoon.worked_hours, 9)  # 8 hours from calendar's attendances + 1 hour of tolerance
+            self.assertEqual(afternoon.check_out, datetime(2024, 1, 1, 18, 0))
+
+    def test_auto_check_out_two_weeks_calendar(self):
+        """Test case: two weeks calendar with different attendances depending on the week. No morning attendance on
+        wednesday of the first week."""
+        Attendance = self.env['hr.attendance']
+        self.company.write({
+            'auto_check_out': True,
+            'auto_check_out_tolerance': 0
+        })
+        self.employee.resource_calendar_id.switch_calendar_type()
+        self.employee.resource_calendar_id.attendance_ids.search([("dayofweek", "=", "2"), ("week_type", '=', '0'), ("day_period", "in", ["morning", "lunch"])]).unlink()
+
+        with freeze_time("2025-03-05 22:00:00"):
+            att = Attendance.create({
+                'employee_id': self.employee.id,
+                'check_in': datetime(2025, 3, 5, 8, 0)
+            })
+            Attendance._cron_auto_check_out()
+            self.assertEqual(att.worked_hours, 4)
+            self.assertEqual(att.check_out, datetime(2025, 3, 5, 12, 0))
+
+        with freeze_time("2025-03-12 22:00:00"):
+            att = Attendance.create({
+                'employee_id': self.employee.id,
+                'check_in': datetime(2025, 3, 12, 8, 0),
+            })
+            Attendance._cron_auto_check_out()
+            self.assertEqual(att.worked_hours, 8)
+            self.assertEqual(att.check_out, datetime(2025, 3, 12, 17, 0))
+
     @freeze_time("2024-02-1 14:00:00")
     def test_absence_management(self):
         self.company.write({