[FIX] figures: fix non-deterministic figure order export

In a3ddce5, we introduced a way to
ensure deterministic order of figures when exporting a sheet. However,
this way was not applied when duplicating sheets, which could lead to
non-deterministic order of figures in the duplicated sheet.

closes #7526

Task: 5092281
Signed-off-by: Adrien Minne (adrm) <[email protected]>

Author: pro-odoo

src/plugins/core/figures.ts

@@ -124,7 +124,8 @@ export class FigurePlugin extends CorePlugin<FigureState> implements FigureState
         }
         break;
       case "DUPLICATE_SHEET": {
-        for (const figureId in this.figures[cmd.sheetId]) {
+        for (const figure of this.getFigures(cmd.sheetId)) {
+          const figureId = figure.id;
           const fig = this.figures[cmd.sheetId]?.[figureId];
           if (!fig) {
             continue;

tests/collaborative/collaborative.test.ts

@@ -1110,3 +1110,31 @@ test("UI plugins cannot refuse core command and de-synchronize the users", () =>
   expect([alice, bob]).toHaveSynchronizedValue((user) => getCellContent(user, "A1"), "hello");
   featurePluginRegistry.remove("myUIPlugin");
 });
+
+test("Export of figures should be in the same order in all users", () => {
+  const { network, alice, bob, charlie } = setupCollaborativeEnv();
+  charlie.dispatch("CREATE_FIGURE", {
+    figureId: "figureId",
+    tag: "tag",
+    offset: { x: 0, y: 0 },
+    col: 4,
+    row: 7,
+    size: { width: 100, height: 100 },
+    sheetId: "Sheet1",
+  });
+  redo(charlie);
+
+  charlie.dispatch("UPDATE_CELL", { col: 4, row: 7, content: "2", sheetId: "Sheet1" });
+  undo(charlie);
+  alice.dispatch("DUPLICATE_SHEET", {
+    sheetId: "Sheet1",
+    sheetIdTo: "duplicateSheetId",
+    sheetNameTo: "Copy of Sheet1",
+  });
+  network.concurrent(() => {
+    redo(charlie);
+    bob.dispatch("DELETE_FIGURE", { figureId: "figureId", sheetId: "Sheet1" });
+  });
+  expect([alice, bob, charlie]).toHaveSynchronizedEvaluation();
+  expect([alice, bob, charlie]).toHaveSynchronizedExportedData();
+});