Skip to content

Conversation

@pro-odoo
Copy link
Collaborator

In a3ddce5, we introduced a way to ensure deterministic order of figures when exporting a sheet. However, this way was not applied when duplicating sheets, which could lead to non-deterministic order of figures in the duplicated sheet.

Task: 5092281

Description:

description of this task, what is implemented and why it is implemented that way.

Task: TASK_ID

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

@robodoo
Copy link
Collaborator

robodoo commented Nov 25, 2025

Pull request status dashboard

Copy link
Contributor

@hokolomopo hokolomopo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robodoo
Copy link
Collaborator

robodoo commented Nov 26, 2025

@hokolomopo you may want to rebuild or fix this PR as it has failed CI.

@pro-odoo
Copy link
Collaborator Author

Oups

In a3ddce5, we introduced a way to
ensure deterministic order of figures when exporting a sheet. However,
this way was not applied when duplicating sheets, which could lead to
non-deterministic order of figures in the duplicated sheet.

Task: 5092281
@pro-odoo pro-odoo force-pushed the 19.0-fix-non-deterministic-figure-order-pro branch from 9ee1629 to 8d3591b Compare November 27, 2025 07:55
@pro-odoo
Copy link
Collaborator Author

@hokolomopo Updated :)

@hokolomopo
Copy link
Contributor

@robodoo r+

@robodoo robodoo closed this in 666c6de Nov 28, 2025
@fw-bot fw-bot deleted the 19.0-fix-non-deterministic-figure-order-pro branch December 5, 2025 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants