[IMP] estate: Chapter 10

Author: qucol-odoo

estate/models/estate_properties.py

@@ -1,5 +1,6 @@
 from odoo import api, fields, models
-from odoo.exceptions import UserError
+from odoo.exceptions import UserError, ValidationError
+from odoo.tools import float_compare
 
 DEFAULT_GARDEN_AREA = 10
 DEFAULT_GARDEN_ORIENTATION = "north"
@@ -8,6 +9,14 @@
 class PropertyModel(models.Model):
     _name = "estate.property"
     _description = "Estate Property model"
+    _check_positive_expected_price = models.Constraint(
+        "CHECK(expected_price >= 0)",
+        "The expected price must be positive."
+    )
+    _check_positive_selling_price = models.Constraint(
+        "CHECK(selling_price >= 0)",
+        "The selling price must be positive"
+    )
 
     name = fields.Char(required=True)
     description = fields.Text()
@@ -79,3 +88,9 @@ def mark_as_cancelled(self):
                 raise UserError("A sold property cannot be set as cancelled.")
             record.state = "cancelled"
         return True
+
+    @api.constrains("selling_price", "expected_price")
+    def _check_selling_price(self):
+        for record in self:
+            if record.selling_price and float_compare(record.selling_price, record.expected_price * .9, 0) == -1:
+                raise ValidationError(r"The selling price cannot be lower than 90% of the expected price.")

estate/models/estate_property_offers.py

@@ -17,11 +17,15 @@ class PropertyOfferModel(models.Model):
     property_id = fields.Many2one("estate.property", required=True)
     validity = fields.Integer(default=7)
     date_deadline = fields.Date(compute="_compute_deadline", inverse="_inverse_deadline")
+    _check_price = models.Constraint(
+        "CHECK(price >= 0)",
+        "The price of the offer must be positive."
+    )
 
     @api.depends("validity")
     def _compute_deadline(self):
         for record in self:
-            record.date_deadline = fields.Date.add(record.create_date, days=record.validity) if record.create_date else None
+            record.date_deadline = fields.Date.add((record.create_date or fields.Datetime.now()), days=record.validity)
 
     def _inverse_deadline(self):
         for record in self:

estate/models/estate_property_tags.py

@@ -4,5 +4,9 @@
 class PropertyTagModel(models.Model):
     _name = "estate.property.tag"
     _description = "Estate Property Tag model"
+    _check_tag_uniqueness = models.Constraint(
+        "UNIQUE(name)",
+        "Each tag should have a unique name."
+    )
 
     name = fields.Char(required=True)

estate/models/estate_property_types.py

@@ -4,5 +4,9 @@
 class PropertyTypeModel(models.Model):
     _name = "estate.property.type"
     _description = "Estate Property Type model"
+    _check_type_uniqueness = models.Constraint(
+        "UNIQUE(name)",
+        "Each type should have a unique name."
+    )
 
     name = fields.Char(required=True)

estate/views/estate_property_offer_views.xml

@@ -21,9 +21,6 @@
         <field name="arch" type="xml">
             <form string="Property Offer">
                 <sheet>
-                    <h1>
-                        <field name="property_id"/>
-                    </h1>
                     <group>
                         <field name="price"/>
                         <field name="partner_id"/>

estate/views/estate_property_views.xml

@@ -90,7 +90,7 @@
                 <field name="bedrooms"/>
                 <field name="living_area"/>
                 <field name="facades"/>
-                <filter name="State" domain="['|', ('state', '=', 'new'), ('state', '=', 'received')]"/>
+                <filter name="State" domain="[('state', 'in', ('new', 'received'))]"/>
                 <filter name="postcode" context="{'group_by': 'postcode'}"/>
             </search>
         </field>