[IMP] estate : add statusbar, helper text and refined sold constrains

- status will not change to sold/cancelled unless an offer is accepted.
- helper text added to visibility field.
- state field is added at the header of form view.

Author: satp-odoo

estate/models/estate_property.py

@@ -7,6 +7,7 @@
 class EstateModel(models.Model):
     _name = "estate.property"
     _description = "Real Estate Advertisement Model"
+    _order = "id desc"
 
     name = fields.Char(required=True)
     description = fields.Text()
@@ -25,15 +26,15 @@ class EstateModel(models.Model):
     garden_area = fields.Integer()
     state = fields.Selection(
         string="state",
-        default="New",
+        default="new",
         required=True,
         copy=False,
         selection=[
-            ("New", "New"),
-            ("Offer Received", "Offer Received"),
-            ("Offer Accepted", "Offer Accepted"),
-            ("Sold", "Sold"),
-            ("Cancelled", "Cancelled"),
+            ("new", "New"),
+            ("offer_received", "Offer Received"),
+            ("offer_accepted", "Offer Accepted"),
+            ("sold", "Sold"),
+            ("cancelled", "Cancelled"),
         ],
     )
     garden_orientation = fields.Selection(
@@ -51,8 +52,8 @@ class EstateModel(models.Model):
     salesman = fields.Many2one("res.users")
     tag_ids = fields.Many2many("estate.property.tag")
     offer_ids = fields.One2many("estate.property.offer", inverse_name="property_id")
-    total_area = fields.Float(compute="_compute_total_area")
-    best_price = fields.Float(compute="_compute_best_price")
+    total_area = fields.Float(compute="_compute_total_area", store=True)
+    best_price = fields.Float(compute="_compute_best_price", store=True)
 
     _sql_constraints = [
         (
@@ -97,18 +98,20 @@ def _compute_best_price(self):
     @api.onchange("garden")
     def _set_garden_default_values(self):
         if self.garden:
-            self.garden_area = 10
-            self.garden_orientation = "north"
+            self.write({"garden_area": 10, "garden_orientation": "north"})
         else:
-            self.garden_area = 0
-            self.garden_orientation = ""
+            self.write({"garden_area": 0, "garden_orientation": ""})
 
     def action_property_sold(self):
-        if self.state in ["Sold", "Cancelled"]:
+        if self.state in ["sold", "cancelled"]:
             raise UserError(f"Property is already {self.state}")
-        self.state = "Sold"
+        if float_is_zero(self.selling_price, precision_rounding=0.01):
+            raise UserError(
+                "Atleast one offer must be accepted before selling the property"
+            )
+        self.state = "sold"
 
     def action_property_cancelled(self):
-        if self.state in ["Sold", "Cancelled"]:
+        if self.state in ["sold", "cancelled"]:
             raise UserError(f"Property is already {self.state}")
-        self.state = "Cancelled"
+        self.state = "cancelled"

estate/models/estate_property_offer.py

@@ -6,14 +6,18 @@
 class EstateOfferModel(models.Model):
     _name = "estate.property.offer"
     _description = "Real Estate Property Offer Model"
+    _order = "price desc"
 
     price = fields.Float()
     status = fields.Selection(
-        [("Accepted", "Accepted"), ("Refused", "Refused")], copy=False
+        [("accepted", "Accepted"), ("refused", "Refused")], copy=False
     )
     partner_id = fields.Many2one("res.partner", required=True)
     property_id = fields.Many2one("estate.property", required=True)
-    validity = fields.Integer(default=7)
+    validity = fields.Integer(
+        default=7,
+        help="offer validity period in days; the offer will be automatically refused when this expires.",
+    )
     date_deadline = fields.Date(default=fields.Date.today() + timedelta(days=7))
 
     _sql_constraints = [
@@ -41,20 +45,24 @@ def _inverse_date_deadline(self):
 
     def action_offer_confirm(self):
         for record in self:
-            if record.status in ["Accepted", "Refused"]:
+            if record.status in ["accepted", "refused"]:
                 raise UserError(f"Offer is already {record.status}")
-
+            # breakpoint()
             for offer in record.property_id.offer_ids:
                 if offer.id == record.id:
-                    record.status = "Accepted"
-                    record.property_id.state = "Offer Accepted"
-                    record.property_id.buyer = record.partner_id
-                    record.property_id.selling_price = record.price
+                    record.status = "accepted"
+                    record.property_id.write(
+                        {
+                            "state": "offer_accepted",
+                            "buyer": record.partner_id,
+                            "selling_price": record.price,
+                        }
+                    )
                 else:
-                    offer.status = "Refused"
+                    offer.status = "refused"
 
     def action_offer_cancel(self):
         for record in self:
-            if record.status in ["Accepted", "Refused"]:
+            if record.status in ["accepted", "refused"]:
                 raise UserError(f"Offer is already {record.status}")
-            record.status = "Refused"
+            record.status = "refused"

estate/models/estate_property_tag.py

@@ -4,6 +4,7 @@
 class EstateTagModel(models.Model):
     _name = "estate.property.tag"
     _description = "Real Estate Property Tag Model"
+    _order = "name"
 
     name = fields.Char(required=True)
 

estate/models/estate_property_type.py

@@ -4,8 +4,11 @@
 class EstateTypeModel(models.Model):
     _name = "estate.property.type"
     _description = "Real Estate Property Type Model"
+    _order = "name"
 
     name = fields.Char(required=True)
+    property_ids = fields.One2many("estate.property", "property_type_id")
+    sequence = fields.Integer("Sequence", default=1, help="Used to change the sequence of Property Types")
 
     _sql_constraints = [
         (

estate/views/estate_property_offer_views.xml

@@ -20,8 +20,8 @@
                 <field name="partner_id" string="Partner" />
                 <field name="validity" string="Validity" />
                 <field name="date_deadline" string="Deadline" />
-                <button name="action_offer_confirm" type="object" icon="fa-check" />
-                <button name="action_offer_cancel" type="object" icon="fa-times" />
+                <button name="action_offer_confirm" type="object" icon="fa-check" invisible="status == 'refused'" />
+                <button name="action_offer_cancel" type="object" icon="fa-times" invisible="status == 'refused'" />
                 <field name="status" string="Status" />
             </list>
         </field>

estate/views/estate_property_type_views.xml

@@ -1,6 +1,17 @@
 <?xml version="1.0"?>
 
 <odoo>
+
+    <record id="estate_property_type_view_list" model="ir.ui.view">
+        <field name="name">estate.property.type.view.list</field>
+        <field name="model">estate.property.type</field>
+        <field name="arch" type="xml">
+            <list name="estate_property_type_list" string="Estate Property Type">
+                <field name="sequence" widget="handle" />
+                <field name="name"></field>
+            </list>
+        </field>
+    </record>
     <record id="action_estate_property_type" model="ir.actions.act_window">
         <field name="name">Property Types</field>
         <field name="res_model">estate.property.type</field>
@@ -11,4 +22,25 @@
             </p>
         </field>
     </record>
+    <record id="action_estate_property_type_form" model="ir.ui.view">
+        <field name="name">Properties by Types</field>
+        <field name="model">estate.property.type</field>
+        <field name="arch" type="xml">
+            <form>
+                <sheet>
+                    <notebook>
+                        <page name="properties" string="Properties">
+                            <field name="property_ids">
+                                <list>
+                                    <field name="name" string="Title" />
+                                    <field name="expected_price" string="Expected Price" />
+                                    <field name="state" string="State" />
+                                </list>
+                            </field>
+                        </page>
+                    </notebook>
+                </sheet>
+            </form>
+        </field>
+    </record>
 </odoo>

estate/views/estate_property_views.xml

@@ -34,6 +34,7 @@
                 <header>
                     <button name="action_property_sold" type="object" string="Sold"/>
                     <button name="action_property_cancelled" type="object" string="Cancelled"/>
+                    <field name="state" widget="statusbar" statusbar_visible="new,offer_received,offer_accepted,sold" />
                 </header>
                 <sheet>
                     <div>
@@ -98,7 +99,7 @@
                 <field name="bedrooms" string="Bedrooms" />
                 <field name="living_area" string="Living Area (sqm)" />
                 <field name="facades" string="Facades" />
-                <filter string="Available" name="state" domain="['|', ('state', '=', 'New'), ('state', '=', 'Offer Received')]"/>
+                <filter string="Available" name="state" domain="['|', ('state', '=', 'new'), ('state', '=', 'offer_received')]"/>
                 <group>
                     <filter string="Postcode" name="postcode" context="{'group_by': 'postcode'}"/>
                 </group>