[Fix] handeled comments in the PR

- modify the way of getting the best price
- removed hard coded styles
- remove unwanted dependencies
- make code more clear

Author: A-Yehia19

estate/models/estate_property.py

@@ -67,10 +67,7 @@ def _compute_total_area(self):
     @api.depends('offer_ids.price')
     def _compute_best_price(self):
         for record in self:
-            best = 0
-            for offer in record.offer_ids:
-                best = max(best, offer.price)
-            record.best_price = best
+            record.best_price = max(record.offer_ids.mapped('price')) if record.offer_ids else 0.0
 
     @api.onchange('garden')
     def _onchange_garden(self):

estate/models/estate_property_offer.py

@@ -31,10 +31,9 @@ def _compute_validity(self):
 
     def _inverse_validity(self):
         for record in self:
+            record.date_deadline = fields.Date.today()
             if record.validity:
-                record.date_deadline = fields.Date.today() + timedelta(days=record.validity)
-            else:
-                record.date_deadline = fields.Date.today()
+                record.date_deadline += timedelta(days=record.validity)
 
     def action_accept_offer(self):
         for record in self:

estate/views/estate_property_views.xml

@@ -9,7 +9,7 @@
                 decoration-muted="state == 'sold'">
                 <field name="name" />
                 <field name="property_type_id" />
-                <field name="date_availability" width="200vw" optional="true" />
+                <field name="date_availability" optional="true" />
             </list>
         </field>
     </record>

estate_account/__manifest__.py

@@ -6,7 +6,7 @@
     'license': 'LGPL-3',
     'application': True,
     'installable': True,
-    'depends': ['base', 'estate', 'account'],
+    'depends': ['estate', 'account'],
     'data': [
         'security/ir.model.access.csv',
     ],