[IMP] [FIX] Overall Code polishing and debugging the runbot.

- Polished the code to respect the coding guidelines.
-  Corrected the order of views within the menifest of the 'estate' module.

This is an exercise on the tutorial "Server Framework 101: Chapter 15"

Author: 3amo-magdy

estate/__manifest__.py

@@ -9,9 +9,9 @@
     ],
     'data': [
         "views/estate_property_views.xml",
+        "views/estate_property_offer_views.xml",
         "views/estate_property_type_views.xml",
         "views/estate_property_tag_views.xml",
-        "views/estate_property_offer_views.xml",
         "views/estate_menus.xml",
         "security/ir.model.access.csv",
         "views/res_users_views.xml",

estate/models/estate_property.py

@@ -47,7 +47,7 @@ class EstateProperty(models.Model):
     offer_ids = fields.One2many('estate.property.offer', 'property_id')
 
     # Computed Fields
-    total_area =fields.Integer('Property Total Area', compute='_calculate_total_area')
+    total_area = fields.Integer('Property Total Area', compute='_calculate_total_area')
     best_price = fields.Float('Property Best Offer', digits=(16, 2), readonly=True, copy=False, compute='_get_best_price')
 
     # Ordering
@@ -63,19 +63,19 @@ class EstateProperty(models.Model):
     @api.constrains('selling_price')
     def _check_selling_price_not_lower_90p_expected_price(self):
         for property in self:
-            if property.selling_price==0:
+            if property.selling_price == 0:
                 continue
             comparing_result = tools.float_compare(property.selling_price, 0.9 * property.expected_price, precision_digits=6)
             if comparing_result < 0:
                 raise ValidationError("Can't accept an offer with an amount less than 90% of the expected price.")
 
     @api.depends('offer_ids')
     def _get_best_price(self):
-        _best_offer = 0
         for property in self:
+            best_offer = 0
             for offer in property.offer_ids:
-                _best_offer = max(_best_offer, offer.price)
-            property.best_price = _best_offer
+                best_offer = max(best_offer, offer.price)
+            property.best_price = best_offer
 
     @api.depends('living_area', 'garden_area')
     def _calculate_total_area(self):
@@ -112,7 +112,6 @@ def action_property_cancel(self):
             property.state = 'cancelled'
         return True
 
-    # Offers Interactions
     # Update Property Status based on offer creations/removals
     @api.onchange('offer_ids')
     def _update_property_state(self):
@@ -162,4 +161,3 @@ def _unlink_except_new_cancelled(self):
         for property in self:
             if property.state not in ('new', 'cancelled'):
                 raise ValidationError("You can't delete properties that are neither new nor cancelled.")
-

estate/models/estate_property_offer.py

@@ -1,4 +1,4 @@
-from datetime import timedelta, datetime
+from datetime import timedelta
 from odoo import fields, models, api
 from odoo.exceptions import ValidationError
 
@@ -33,29 +33,29 @@ class EstatePropertyOffer(models.Model):
     def _compute_offer_deadline(self):
         for offer in self:
             if not offer.create_date:
-                _create_date = fields.Date.today()
+                create_date = fields.Date.today()
             else:
-                _create_date = offer.create_date
-            offer.deadline = _create_date + timedelta(days=offer.validity_days)
+                create_date = offer.create_date
+            offer.deadline = create_date + timedelta(days=offer.validity_days)
 
     def _inverse_offer_deadline(self):
         for offer in self:
             if not offer.create_date:
-                _create_date = fields.Date.today()
+                create_date = fields.Date.today()
             else:
-                _create_date = offer.create_date.date()
-            offer.validity_days = (offer.deadline - _create_date).days
+                create_date = offer.create_date.date()
+            offer.validity_days = (offer.deadline - create_date).days
 
     # Actions
     def action_offer_accept(self):
         for offer in self:
-            if not offer.status == 'accepted':
+            if offer.status != 'accepted':
                 offer.property_id._notify_offer_accepted(offer)
         return True
 
     def action_offer_refuse(self):
         for offer in self:
-            if not offer.status == 'refused':
+            if offer.status != 'refused':
                 offer.property_id._notify_offer_refused(offer)
         return True
 

estate/models/estate_property_tag.py

@@ -3,7 +3,7 @@
 
 class EstatePropertyTag(models.Model):
     _name = 'estate.property.tag'
-    _description =  "property tag description"
+    _description = "property tag description"
     name = fields.Char('Property Tag', required=True)
     color = fields.Integer()
 

estate/models/estate_property_type.py

@@ -10,7 +10,6 @@ class EstatePropertyType(models.Model):
     name = fields.Char('Property Type', required=True)
     _order = "sequence, name"
 
-    name = fields.Char('Property Type', required=True)
     description = fields.Char('Description', required=False)
     property_ids = fields.One2many('estate.property', 'property_type_id', string='Properties')
 

estate/models/res_partner.py

@@ -1,5 +1,6 @@
 from odoo import fields, models
 
+
 class User(models.Model):
     _inherit = "res.partner"
-    property_ids = fields.One2many(comodel_name='estate.property', inverse_name="buyer_id")
+    property_ids = fields.One2many(comodel_name='estate.property', inverse_name="buyer_id")

estate/models/res_users.py

@@ -1,5 +1,6 @@
 from odoo import fields, models
 
+
 class User(models.Model):
     _inherit = "res.users"
-    property_ids = fields.One2many(comodel_name='estate.property', inverse_name="salesman_id")
+    property_ids = fields.One2many(comodel_name='estate.property', inverse_name="salesman_id")

estate_account/__init__.py

@@ -0,0 +1 @@
+from . import models

estate_account/__manifest__.py

@@ -0,0 +1,21 @@
+{
+    'name': 'estate_account',
+    'version': '1.0',
+    'sequence': 15,
+    'summary': 'estate-account summary',
+    'description': "",
+    'depends': [
+        'estate',
+        'account'
+    ],
+    'data': [
+        'views/account_move_views.xml',
+        'views/estate_property_views.xml',
+        # "security/ir.model.access.csv"
+    ],
+    'demo': [
+    ],
+    'installable': True,
+    'application': True,
+    'auto_install': False
+}

estate_account/models/__init__.py

@@ -0,0 +1,2 @@
+from . import account_move
+from . import estate_property

estate_account/models/account_move.py

@@ -1,4 +1,4 @@
-from odoo import fields, models, Command
+from odoo import fields, models
 
 
 class AccountMove(models.Model):

estate_account/models/estate_property.py

@@ -22,12 +22,11 @@ def _create_account_move(self):
                             Command.create(dict(name="6% Down Payment", quantity=0.06, price_unit=offer.price)),
                             Command.create(dict(name="Administrative Fees", quantity=1, price_unit=100))
                         ],
-                        property_id = self.id,
+                        property_id=self.id,
                     )]
                 )
                 return
 
-
     def action_property_sold(self):
         for property in self:
             property._create_account_move()

estate_account/views/account_move_views.xml

@@ -0,0 +1,9 @@
+<?xml version="1.0"?>
+<odoo>
+    <record id="estate_property_account_move_action_statbutton" model="ir.actions.act_window">
+        <field name="name">Invoices</field>
+        <field name="res_model">account.move</field>
+        <field name="view_mode">list</field>
+        <field name="domain">[('property_id', '=', active_id)]</field>
+    </record>
+</odoo>