Skip to content

Commit bce32b6

Browse files
committed
[FIX] Addressed code review feedback
1 parent 8dd8fcc commit bce32b6

File tree

6 files changed

+32
-5
lines changed

6 files changed

+32
-5
lines changed

.gitignore

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -127,3 +127,5 @@ dmypy.json
127127

128128
# Pyre type checker
129129
.pyre/
130+
131+
.vscode/launch.js

.vscode/launch.json

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
{
2+
// Use IntelliSense to learn about possible attributes.
3+
// Hover to view descriptions of existing attributes.
4+
// For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
5+
"version": "0.2.0",
6+
"configurations": [
7+
{
8+
"name": "Run (Update)",
9+
"type": "debugpy",
10+
"request": "launch",
11+
"python": "/usr/bin/python3",
12+
"program": "/home/odoo/odoo/odoo-bin",
13+
"console": "integratedTerminal",
14+
"args": [
15+
"--database", "rd-demo",
16+
"--dev", "xml",
17+
// "-u", "we_guarantee",
18+
"--addons-path", "/home/odoo/enterprise,/home/odoo/odoo/addons,/home/odoo/tutorials",
19+
"--log-level", "info",
20+
"--limit-time-real=0",
21+
"--limit-time-cpu=0",
22+
],
23+
"variablePresentation": {},
24+
},
25+
]
26+
}

awesome_dashboard/static/src/dashboard/config_dialog/config_dialog.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ export class ConfigDialog extends Component {
88
static components = { Dialog, CheckBox };
99
static props = ["close", "items", "disabledItems", "onUpdateConfigs"];
1010
setup() {
11-
// create object for each item with an enabled property
11+
1212
this.items = useState(this.props.items.map((item) => {
1313
return {
1414
...item,
@@ -18,7 +18,6 @@ export class ConfigDialog extends Component {
1818

1919
}
2020

21-
// adds the unchecked item to the disabled list
2221
onChange(checkedItems, Item) {
2322
Item.enabled = checkedItems;
2423

awesome_dashboard/static/src/dashboard/dashboard.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ class AwesomeDashboard extends Component {
3030
onUpdateConfigs: this.updateConfigs.bind(this),
3131
});
3232
}
33-
// update the list of disabeled items
33+
3434
updateConfigs(newDisabledItems) {
3535
this.state.disabledItems = newDisabledItems;
3636
user.setUserSettings("disabled_items", this.state.disabledItems)

awesome_dashboard/static/src/dashboard/numbercard/number_card.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<?xml version="1.0" encoding="UTF-8" ?>
22
<templates xml:space="preserve">
33

4-
<t t-name="awesome_dashboard.NumberCard" owl='1'>
4+
<t t-name="awesome_dashboard.NumberCard" >
55
<div class="d-flex flex-wrap">
66
<t t-esc="props.title"/>
77
<div class="fs-1 fw-bold text-success text-center">

awesome_dashboard/static/src/dashboard/piechartcard/piechart_card.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<?xml version="1.0" encoding="UTF-8" ?>
22
<templates xml:space="preserve">
33

4-
<t t-name="awesome_dashboard.PieChartCard" owl='1'>
4+
<t t-name="awesome_dashboard.PieChartCard" >
55
<div t-att-class="'h-100 ' + props.class">
66
<div class="h-100 position-relative">
77
<t t-esc="props.title"/>

0 commit comments

Comments
 (0)