[ADD] estate: extend CRUD rules and user form with property management

. Prevent deletion of properties unless state is 'New' or 'Cancelled'
. On offer creation: set related property state to 'Offer Received'
. Raise an error if an offer is lower than an existing one
. Show salesperson's available properties directly on the user form
. Add a new tab in user settings to manage linked properties

Author: pusu-odoo

estate/__manifest__.py

@@ -10,6 +10,7 @@
         "views/estate_property_type_views.xml",
         "views/estate_property_tag_views.xml",
         "views/estate_menus.xml",
+        "views/res_users_views.xml",
     ],
     "license": "LGPL-3",
     "application": True,

estate/models/__init__.py

@@ -2,3 +2,4 @@
 from . import estate_property_type
 from . import estate_property_tag
 from . import estate_property_offer
+from . import res_users

estate/models/estate_property.py

@@ -1,7 +1,6 @@
 from datetime import timedelta
 from odoo import models, fields, api
-from odoo.exceptions import ValidationError
-from odoo.exceptions import UserError
+from odoo.exceptions import ValidationError, UserError
 from odoo.tools import float_is_zero, float_compare
 
 
@@ -57,13 +56,11 @@ class EstateProperty(models.Model):
             ("sold", "Sold"),
             ("cancelled", "Cancelled"),
         ],
-        compute="_compute_state",
-        store=True,
     )
     salesman_id = fields.Many2one(
         "res.users", string="Salesman", default=lambda self: self.env.user
     )
-    buyer_id = fields.Many2one("res.partner", string="Buyer", copy=False)
+    buyer_id = fields.Many2one("res.partner", string="Buyer", copy=False, readonly=True)
 
     tag_ids = fields.Many2many(
         "estate.property.tag",
@@ -83,6 +80,22 @@ class EstateProperty(models.Model):
         compute="_compute_best_price",
     )
 
+    _sql_constraints = [
+        (
+            "check_expected_price",
+            "CHECK(expected_price > 0)",
+            "The expected price must be greater than 0.",
+        ),
+    ]
+
+    @api.ondelete(at_uninstall=False)
+    def _unlink_check(self):
+        for property in self:
+            if property.state not in ["new", "cancelled"]:
+                raise UserError(
+                    "You cannot delete a property that is not new or cancelled."
+                )
+
     @api.depends("living_area", "garden_area", "garden")
     def _compute_total_area(self):
         for property in self:
@@ -95,14 +108,6 @@ def _compute_best_price(self):
         for property in self:
             property.best_price = max(property.offer_ids.mapped("price"), default=0.0)
 
-    @api.depends("offer_ids")
-    def _compute_state(self):
-        for record in self:
-            if record.offer_ids and record.selling_price == 0.0:
-                record.state = "offer received"
-            else:
-                record.state = "new"
-
     @api.onchange("garden")
     def _onchange_garden(self):
         for property in self:
@@ -135,14 +140,6 @@ def action_set_cancelled(self):
             elif property.state == "sold":
                 raise UserError("A sold property cannot be cancelled.")
 
-    _sql_constraints = [
-        (
-            "check_expected_price",
-            "CHECK(expected_price > 0)",
-            "The expected price must be greater than 0.",
-        ),
-    ]
-
     @api.constrains("selling_price", "expected_price")
     def _check_selling_price(self):
         for property in self:

estate/models/estate_property_offer.py

@@ -36,6 +36,23 @@ class EstatePropertyOffer(models.Model):
         store=True,
     )
 
+    _sql_constraints = [
+        ("check_price", "CHECK(price > 0)", "The price must be greater than 0."),
+    ]
+
+    @api.model_create_multi
+    def create(self, vals_list):
+        for record in vals_list:
+            property = self.env["estate.property"].browse(record["property_id"])
+
+            if record.get("price") < property.best_price:
+                raise UserError(
+                    "You cannot create an offer lower than an existing one."
+                )
+
+            property.state = "offer received"
+        return super().create(vals_list)
+
     @api.depends("validity")
     def _compute_date_deadline(self):
         for offer in self:
@@ -58,22 +75,18 @@ def _inverse_date_deadline(self):
             else:
                 offer.validity = 0
 
-    # @api.onchange("date_deadline")
-    # def _onchange_date_deadline(self):
-    #     for offer in self:
-    #         if offer.date_deadline:
-    #             base_date = fields.Date.to_date(offer.create_date) if offer.create_date else fields.Date.context_today(offer)
-    #             offer.validity = (offer.date_deadline - base_date).days
-    #         else:
-    #             offer.validity = 0
-
     def action_set_accepted(self):
         for offer in self:
             if offer.property_id.selling_price == 0.0:
-                offer.status = "accepted"
-                offer.property_id.state = "offer accepted"
-                offer.property_id.selling_price = offer.price
-                offer.property_id.buyer_id = offer.partner_id
+                offer.write({"status": "accepted"})
+
+                offer.property_id.write(
+                    {
+                        "state": "offer accepted",
+                        "selling_price": offer.price,
+                        "buyer_id": offer.partner_id.id,
+                    }
+                )
 
                 other_offers = offer.property_id.offer_ids - offer
 
@@ -83,16 +96,8 @@ def action_set_accepted(self):
 
     def action_set_refused(self):
         for offer in self:
-            if offer.status is False:
-                offer.status = "refused"
-            elif offer.status == "accepted":
-                offer.status = "refused"
+            if offer.status == "accepted":
                 offer.property_id.state = "offer received"
                 offer.property_id.buyer_id = False
                 offer.property_id.selling_price = 0.0
-            else:
-                raise UserError("This offer is not accepted, so it cannot be refused.")
-
-    _sql_constraints = [
-        ("check_price", "CHECK(price > 0)", "The price must be greater than 0."),
-    ]
+            offer.status = "refused"

estate/models/estate_property_tag.py

@@ -4,11 +4,12 @@
 class EstatePropertyTag(models.Model):
     _name = "estate.property.tag"
     _description = "Estate Property Tag"
-    _sql_constraints = [
-        ("unique_name", "UNIQUE(name)", "A tag with same name is already exists."),
-    ]
     _order = "name asc"
 
     name = fields.Char(string="Tag Name", required=True)
     description = fields.Text(string="Description")
     color = fields.Integer(string="Color")
+
+    _sql_constraints = [
+        ("unique_name", "UNIQUE(name)", "A tag with same name is already exists."),
+    ]

estate/models/estate_property_type.py

@@ -4,9 +4,6 @@
 class EstatePropertyType(models.Model):
     _name = "estate.property.type"
     _description = "Estate Property Type"
-    _sql_constraints = [
-        ("unique_name", "UNIQUE(name)", "A type with same name is already exists."),
-    ]
     _order = "sequence,name"
 
     name = fields.Char(required=True)
@@ -22,6 +19,10 @@ class EstatePropertyType(models.Model):
 
     offer_count = fields.Integer("Offers", compute="_compute_offer_count")
 
+    _sql_constraints = [
+        ("unique_name", "UNIQUE(name)", "A type with same name is already exists."),
+    ]
+
     @api.depends("offer_ids")
     def _compute_offer_count(self):
         for record in self:

estate/models/res_users.py

@@ -0,0 +1,12 @@
+from odoo import fields, models
+
+
+class ResUser(models.Model):
+    _inherit = "res.users"
+
+    property_ids = fields.One2many(
+        "estate.property",
+        "salesman_id",
+        string="Properties",
+        domain=[("state", "in", ["new", "offer received"])],
+    )

estate/views/estate_menus.xml

@@ -10,4 +10,5 @@
             <menuitem id="estate_property_tag_menu_action" action="estate_property_tag_action"/>
         </menuitem>
     </menuitem>
-</odoo> 
+</odoo>
+ 

estate/views/estate_property_offer_views.xml

@@ -42,4 +42,4 @@
         </field>
     </record>
 
-</odoo>
+</odoo>

estate/views/estate_property_tag_views.xml

@@ -39,4 +39,4 @@
             </form>
         </field>
     </record>
-</odoo>
+</odoo>