You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
One such example is "getParent". In PostModel it will return null if no parent is set, but in TermModel it will return false if no parent is set. I think it would be better to stick with null over false as "empty" type to avoid type mixing.
However, this change has potential to cause issues in existing projects.
The text was updated successfully, but these errors were encountered:
Maybe it's not something to judge but just wanted to pass it on :).
Inside the ComponentRepo, App(.php), RouteManager all basic exceptions are thrown.
Wouldn't it be nice to extend these from a base exception and specify them out, making them less generic: for example a component exception, route exception, etc. Here you can later choose to do something with these exceptions, otherwise, you will catch everything at once.
One such example is "getParent". In PostModel it will return null if no parent is set, but in TermModel it will return false if no parent is set. I think it would be better to stick with null over false as "empty" type to avoid type mixing.
However, this change has potential to cause issues in existing projects.
The text was updated successfully, but these errors were encountered: