Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot read properties of undefined (reading 'length') while changing the dimension #7362

Closed
bishwas-10 opened this issue Mar 8, 2024 · 10 comments · Fixed by #7654
Closed
Assignees

Comments

@bishwas-10
Copy link

bishwas-10 commented Mar 8, 2024

Describe the bug
in the camera feed section of patient
When i change the dimension of screen from one viewport to another for eg dimension: responsive to dimension:iphone SE
its showing me an error of
TypeError: Cannot read properties of undefined (reading 'length')
but once i refresh it goes away

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'camera feed section of patient'
  2. try changing the dimension

Screenshots
If applicable, add screenshots to help explain your problem.
image
image

@r-nikhilkumar
Copy link
Contributor

@rithviknishad, @bishwas-10, can you please assign this to me?

@Shahbaz898414
Copy link

@r-nikhilkumar can you please assign this to me?

@Thanush19
Copy link

hey @rithviknishad , if the issue to be resolved,i can fix this....

@r-nikhilkumar
Copy link
Contributor

@Thanush19 what's your idea to solve this issue?

@rithviknishad rithviknishad added hold waiting for related PR a co-related detail PR is under construction and removed work-in-progress labels Mar 11, 2024
@rithviknishad
Copy link
Member

Waiting for related PR: #6223

@khavinshankar
Copy link
Member

@r-nikhilkumar fork the branch from #6223 and make a pr with the base branch as #6223

cc: @rithviknishad

@r-nikhilkumar
Copy link
Contributor

@khavinshankar , @rithviknishad , Do I have to fork branch "JahnabDutta:qa-testing" and raise pr to the main branch coronasafe:develop??? without any changes?? Did I get it right? please guide...!

@rithviknishad
Copy link
Member

rithviknishad commented Mar 15, 2024

No, You have to branch out from @JahnabDutta 's branch and make a PR to his branch instead of develop.

@r-nikhilkumar
Copy link
Contributor

okay, and do I need to make changes anything in the code or just make pr only?

@khavinshankar
Copy link
Member

@r-nikhilkumar

  1. Create a new branch from "[JahnabDutta:qa-testing](https://github.com/JahnabDutta/care_fe/tree/qa-testing)"
  2. Make necessary changes
  3. Create a pull request with base branch as "[JahnabDutta:qa-testing](https://github.com/JahnabDutta/care_fe/tree/qa-testing)"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
6 participants